Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the VM hanging, when circuit output ranges are used as input ranges for a new circuit. The change fixes the curently hanging tests of the prf and cipher crates of tlsnotary.
When a circuit is executed the input range corresponding to the output range of the circuit output is not marked as
complete
. This leads tois_committed
returning false and the circuit never being executed.Questions
assigned
orall
ofInputView
? Anything else which needs to be adapted for consistency?