From 9255055bc98c2f1a325caf91bac8ce1f52f55ae6 Mon Sep 17 00:00:00 2001 From: Rohit Narurkar Date: Fri, 30 Jun 2023 12:05:15 +0100 Subject: [PATCH] chore: fix clippy warning --- .../src/evm_circuit/util/memory_gadget.rs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/zkevm-circuits/src/evm_circuit/util/memory_gadget.rs b/zkevm-circuits/src/evm_circuit/util/memory_gadget.rs index bf732f45e6..8af1d61a4e 100644 --- a/zkevm-circuits/src/evm_circuit/util/memory_gadget.rs +++ b/zkevm-circuits/src/evm_circuit/util/memory_gadget.rs @@ -21,6 +21,7 @@ use halo2_proofs::{ circuit::Value, plonk::{Error, Expression}, }; +use itertools::Itertools; /// Decodes the usable part of an address stored in a Word pub(crate) mod address_low { @@ -494,10 +495,16 @@ impl bytes: &[u8], ) -> Result<(), Error> { assert_eq!(bytes.len(), MAX_BYTES); - for idx in 0..MAX_BYTES { + for (idx, ((byte_col, &byte_val), selector_col)) in self + .bytes + .iter() + .zip_eq(bytes.iter()) + .zip_eq(self.selectors.iter()) + .enumerate() + { let selector = (addr_start + idx as u64) < addr_end; - self.selectors[idx].assign(region, offset, Value::known(F::from(selector as u64)))?; - self.bytes[idx].assign(region, offset, Value::known(F::from(bytes[idx] as u64)))?; + selector_col.assign(region, offset, Value::known(F::from(selector as u64)))?; + byte_col.assign(region, offset, Value::known(F::from(byte_val as u64)))?; } let is_empty = addr_start >= addr_end;