Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXDL__group attributes dictionary values #165

Open
prjemian opened this issue Nov 17, 2021 · 1 comment
Open

NXDL__group attributes dictionary values #165

prjemian opened this issue Nov 17, 2021 · 1 comment
Assignees
@prjemian
Labels
question
Milestone
v1.0.0-release

Comments

@prjemian
Copy link
Owner

While developing better unit tests for the nxdl_manager module (#163), noticed this line:

punx/punx/nxdl_manager.py

Line 527 in f0e707d

self.attributes[k] = v # FIXME: should be NXDL__attribute instance

The consequences are that the values in the group's .attributes dictionary are text values directly from the XML rather than instances of nxdl_manager.NXDL__attribute.

Seems irregular. Why is this? Should it be changed?
@prjemian prjemian added this to the v1.0.0-release milestone Nov 17, 2021
@prjemian prjemian self-assigned this Nov 17, 2021
prjemian added a commit that referenced this issue Nov 17, 2021
@prjemian
DOC #165
adc75db
@prjemian
Copy link
Owner Author

Still there:

punx/punx/nxdl_manager.py

Line 630 in af8eefc

self.attributes[k] = v # FIXME: should be NXDL__attribute instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
question
Projects
None yet
Milestone
v1.0.0-release
Development

No branches or pull requests
1 participant
@prjemian