Skip to content

Market.sol variable naming #37

@shotaronowhere

Description

@shotaronowhere

L283 just a small typo in the variable name.

uint256 cumWeigths = 0;

should be

uint256 cumWeights = 0;

for clarity. It's fine because the variable name is consistent, but it just kept bothering me while I did a brief review a few weeks ago, didn't find anything obviously erroneous. I didn't completely look over the relevant contracts, probably won't have time for some time. Lots of gas optimization opportunities of course, but presumably that's saved for v2. This typo just kept bothering me, it's completely inconsequential though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions