Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support playing games with players returning just word list #25

Open
aguschin opened this issue Nov 9, 2021 · 0 comments
Open

Support playing games with players returning just word list #25

aguschin opened this issue Nov 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@aguschin
Copy link
Contributor

aguschin commented Nov 9, 2021

For RemotePlayer class, we collect response_time and response_code. Would be good to do the same for Local Player classes. This should not be repeated in each class instance, but rather we should reuse the same piece of code across all classes.

For instance, this could be done with wrapper, wrapping guess() and explain() methods, returning dict with metrics instead of word list.

Also, right now code in game.py (lines 144-152) require all players to return dict, though players in flask_app return list only. We either need to

  • make them return dict and change app.py in flask-app,
  • or support playing games with players which return list instead of dict,
  • or wrap guess and explain methods automatically, so they will actually return dict.
@aguschin aguschin added the enhancement New feature or request label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant