You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For RemotePlayer class, we collect response_time and response_code. Would be good to do the same for Local Player classes. This should not be repeated in each class instance, but rather we should reuse the same piece of code across all classes.
For instance, this could be done with wrapper, wrapping guess() and explain() methods, returning dict with metrics instead of word list.
Also, right now code in game.py (lines 144-152) require all players to return dict, though players in flask_app return list only. We either need to
make them return dict and change app.py in flask-app,
or support playing games with players which return list instead of dict,
or wrap guess and explain methods automatically, so they will actually return dict.
The text was updated successfully, but these errors were encountered:
For RemotePlayer class, we collect response_time and response_code. Would be good to do the same for Local Player classes. This should not be repeated in each class instance, but rather we should reuse the same piece of code across all classes.
For instance, this could be done with wrapper, wrapping
guess()
andexplain()
methods, returning dict with metrics instead of word list.Also, right now code in
game.py
(lines 144-152) require all players to return dict, though players in flask_app return list only. We either need toapp.py
in flask-app,The text was updated successfully, but these errors were encountered: