Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav-Bar Issue #8

Open
vaibhavmodi45 opened this issue Jul 29, 2024 · 5 comments
Open

Nav-Bar Issue #8

vaibhavmodi45 opened this issue Jul 29, 2024 · 5 comments
Assignees

Comments

@vaibhavmodi45
Copy link

On exploring the website on a mobile then there is an issue that arises that the nav-Bar toggle button is not showing the drop down list (which we can expect from it).

@programmer-rahul
Copy link
Owner

Hi @vaibhavmodi45,

Thanks for bringing this up. Actually, the dropdown menu is hidden when the website is opened on small devices because the nav-bar is not yet designed for smaller screens. Given that this is a personal portfolio, I don't think we need a navbar for smaller devices. Perhaps we should remove the navbar-toggle button entirely. What do you think?

@vaibhavmodi45
Copy link
Author

vaibhavmodi45 commented Jul 30, 2024

Hello @programmer-rahul

This is a good idea, we can think about removing it cause on small devices generally users keep scroll so as per that scenario there will be no need for a navbar.

@programmer-rahul
Copy link
Owner

Hi @vaibhavmodi45,

Yes, we can remove the navbar-toggle button as it seems unnecessary for small devices. If you’d like, you can go ahead and make this change.

@vaibhavmodi45
Copy link
Author

Hii @programmer-rahul ,

I've tried to make some updates that are needed by you as we have discussed i.e. the Navbar Icon. I've removed it please make sure and verify it and if all is good then you can merge it.

@programmer-rahul
Copy link
Owner

Hi @vailbhavmodi45,
You also need to remove the code where this dropdown menu icon has been imported and used. Otherwise, it will cause errors because this is no longer available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants