Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster features in storage/consider only current and not stored features #1161

Open
jpadie opened this issue Sep 4, 2024 · 3 comments
Assignees

Comments

@jpadie
Copy link
Contributor

jpadie commented Sep 4, 2024

Suggestion that conformance errors are not automatically fatal errors in all cases. As an example use case:

set an onoff lighting device with colour support and colour temperature support and provide defaults for the mandatory attributes.
then remove colour temperature support.

the deployment will fail for conformance because an attribute is in the device storage that is contrary to the conformance requirements. But this could be silently ignored instead of resulting in a fatal error.

@Apollon77 Apollon77 changed the title Ignore some conformance errors. Update cluster features in storage/consider only current and not stored features Sep 5, 2024
@Apollon77
Copy link
Collaborator

The issue is more that the storage contains meta data about features/clusters that are removed in the meantime ... so we need to see how we might support this.
Formally adding and removing clusters and features and attributes and commands should be possible - especially in a bridge

@jpadie
Copy link
Contributor Author

jpadie commented Sep 5, 2024

The issue is more that the storage contains meta data about features/clusters that are removed in the meantime ... so we need to see how we might support this. Formally adding and removing clusters and features and attributes and commands should be possible - especially in a bridge

agreed that filtering the stored values is possibly a more elegant solution but is there not also a use case where a user may pass in (say) a valid but non-conforming attribute during runtime? would that result in a fatal error (if so, same concern) or be ignored?

@Apollon77
Copy link
Collaborator

if you do a "set" with an unconformant value then you will get an exception. Catch them and you can filter themnm most likely by the Error instance (ValidationError).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

3 participants