Respect the with_spans setting for Annotations

Prior to this change, Annotations would always have span information,
irrespective of the value of the with_spans argument to the parser.

This change changes the behaviour to only include span information if
with_spans if set to True.

Author: leamingrad

fluent.syntax/fluent/syntax/parser.py

@@ -133,7 +133,8 @@ def get_entry_or_junk(self, ps: FluentParserStream) -> ast.EntryType:
             annot = ast.Annotation(
                 err.code, list(err.args) if err.args else None, err.message
             )
-            annot.add_span(error_index, error_index)
+            if self.with_spans:
+                annot.add_span(error_index, error_index)
             junk.add_annotation(annot)
             return junk
 

fluent.syntax/tests/syntax/test_entry.py

@@ -65,7 +65,7 @@ def test_return_junk(self):
                     "arguments": ["="],
                     "code": "E0003",
                     "message": 'Expected token: "="',
-                    "span": {"end": 23, "start": 23, "type": "Span"},
+                    "span": None,
                     "type": "Annotation",
                 }
             ],
@@ -111,7 +111,7 @@ def test_do_not_ignore_invalid_comments(self):
                     "arguments": [" "],
                     "code": "E0003",
                     "message": 'Expected token: " "',
-                    "span": {"end": 21, "start": 21, "type": "Span"},
+                    "span": None,
                     "type": "Annotation",
                 }
             ],