Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge setup.cfg into pyproject.toml #200

Closed
wang-boyu opened this issue Apr 24, 2024 · 4 comments
Closed

ci: merge setup.cfg into pyproject.toml #200

wang-boyu opened this issue Apr 24, 2024 · 4 comments
Labels
ci Release notes label sprint A task that might be good to tackle during sprints!

Comments

@wang-boyu
Copy link
Member

We had two separated files, setup.cfg and pyproject.toml because some fields were marked as experimental back when they were created: #54 (comment). Now that Mesa uses only pyproject.toml, it would be nice to follow its convention, and making it easier to maintain too.

For example in pyproject.toml we have

"mesa~=2.2",

whereas in setup.cfg it is

mesa~=2.1.0

something that I forgot to update in #186.

@wang-boyu wang-boyu added the ci Release notes label label Apr 24, 2024
@EwoutH
Copy link
Member

EwoutH commented Apr 24, 2024

I think we should also remove the setup.py in that case. I think that's still leading?

@EwoutH
Copy link
Member

EwoutH commented Apr 24, 2024

I think this is a good start: pyproject-toml Only thing I don't know how to handle is the scripts in setup.py. Are those still essential?

Feel free to continue working on that branch.

@wang-boyu
Copy link
Member Author

wang-boyu commented Apr 24, 2024

Yes we still need to install js/css dependencies in setup.py. This part for Mesa has been moved into the separate repo https://github.com/projectmesa/mesa-viz-tornado. Mesa-Geo probably doesn't need to do this.

@wang-boyu wang-boyu added the sprint A task that might be good to tackle during sprints! label May 17, 2024
@wang-boyu
Copy link
Member Author

Implemented in #208. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label sprint A task that might be good to tackle during sprints!
Projects
None yet
Development

No branches or pull requests

2 participants