From a81da5be91570343cffaa0fc21053b040dc81e4e Mon Sep 17 00:00:00 2001 From: Luna An Date: Fri, 11 Jan 2019 13:21:08 -0500 Subject: [PATCH] Remove internal from the example project --- .../Custom Menus/CustomUIMenu/CustomUIMenu.swift | 6 +++--- Example/YoshiExample/Custom Menus/DateSelectorMenu.swift | 2 +- .../YoshiExample/Cutstom Class/YoshiBaseEnvironment.swift | 2 +- Example/YoshiExample/ViewController.swift | 2 +- README.md | 6 +++--- Yoshi/QAKit/EnvironmentMenu/YoshiEnvironment.swift | 2 +- .../EnvironmentMenu/YoshiPersistentEnvironment.swift | 2 +- .../xcshareddata/IDEWorkspaceChecks.plist | 8 ++++++++ .../YoshiDateSelectorMenuCellDataSource.swift | 2 +- .../YoshiSingleSelectionMenuItem.swift | 2 +- .../YoshiTableViewMenu/YoshiTableViewSubmenuItem.swift | 2 +- Yoshi/Yoshi/Utility/AppBundleUtility.swift | 2 +- Yoshi/Yoshi/Utility/Color.swift | 2 +- .../DebugDatePickerViewController.swift | 2 +- .../Debug View Controller/DebugViewController.swift | 4 ++-- Yoshi/Yoshi/YoshiConfigurationManager.swift | 2 +- 16 files changed, 28 insertions(+), 20 deletions(-) create mode 100644 Yoshi/Yoshi.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist diff --git a/Example/YoshiExample/Custom Menus/CustomUIMenu/CustomUIMenu.swift b/Example/YoshiExample/Custom Menus/CustomUIMenu/CustomUIMenu.swift index 4c0c868..e85cad1 100644 --- a/Example/YoshiExample/Custom Menus/CustomUIMenu/CustomUIMenu.swift +++ b/Example/YoshiExample/Custom Menus/CustomUIMenu/CustomUIMenu.swift @@ -9,7 +9,7 @@ import Yoshi /// A menu with custom UI. -internal struct CustomUIMenu: YoshiGenericMenu { +struct CustomUIMenu: YoshiGenericMenu { var cellSource: YoshiReusableCellDataSource { return CustomMenuCellDataSource() @@ -21,7 +21,7 @@ internal struct CustomUIMenu: YoshiGenericMenu { } /// UI data source for CustomUIMenu that uses a custom xib file. -internal final class CustomMenuCellDataSource: YoshiReusableCellDataSource { +final class CustomMenuCellDataSource: YoshiReusableCellDataSource { static var nib: UINib? { return UINib(nibName: "CustomCell", bundle: nil) @@ -38,7 +38,7 @@ internal final class CustomMenuCellDataSource: YoshiReusableCellDataSource { } /// A custom UITableViewCell. -internal final class CustomCell: UITableViewCell { +final class CustomCell: UITableViewCell { /// Label outlet from storyboard @IBOutlet weak var label: UILabel! diff --git a/Example/YoshiExample/Custom Menus/DateSelectorMenu.swift b/Example/YoshiExample/Custom Menus/DateSelectorMenu.swift index e7d08db..ce26c5b 100644 --- a/Example/YoshiExample/Custom Menus/DateSelectorMenu.swift +++ b/Example/YoshiExample/Custom Menus/DateSelectorMenu.swift @@ -9,7 +9,7 @@ import Yoshi /// A date selector menu item to be displayed in Yoshi. -internal final class DateSelectorMenu: YoshiDateSelectorMenu { +final class DateSelectorMenu: YoshiDateSelectorMenu { var title: String var subtitle: String? diff --git a/Example/YoshiExample/Cutstom Class/YoshiBaseEnvironment.swift b/Example/YoshiExample/Cutstom Class/YoshiBaseEnvironment.swift index 87ded83..24e2f73 100644 --- a/Example/YoshiExample/Cutstom Class/YoshiBaseEnvironment.swift +++ b/Example/YoshiExample/Cutstom Class/YoshiBaseEnvironment.swift @@ -9,7 +9,7 @@ import Yoshi /// Default basic implementation of YoshiEnvironment protocol. -internal enum YoshiBaseEnvironment: String, YoshiEnvironment, Codable { +enum YoshiBaseEnvironment: String, YoshiEnvironment, Codable { case qa, production diff --git a/Example/YoshiExample/ViewController.swift b/Example/YoshiExample/ViewController.swift index fcc192d..ee086ac 100644 --- a/Example/YoshiExample/ViewController.swift +++ b/Example/YoshiExample/ViewController.swift @@ -8,7 +8,7 @@ import UIKit -internal final class ViewController: UIViewController { +final class ViewController: UIViewController { @IBOutlet private weak var environment: UILabel! { didSet { diff --git a/README.md b/README.md index e29ad6a..c476076 100644 --- a/README.md +++ b/README.md @@ -122,7 +122,7 @@ Yoshi will take care of managing selections and call back the convenient closure To present a date selector menu, create a type that conforms to `YoshiDateSelectorMenu` protocol ```swift -internal final class DateSelectorMenu: YoshiDateSelectorMenu { +final class DateSelectorMenu: YoshiDateSelectorMenu { var title: String var subtitle: String? @@ -156,7 +156,7 @@ If you find your debug menu getting out of hand, you can organize it into submen ```swift -internal final class Submenu: YoshiSubmenu { +final class Submenu: YoshiSubmenu { let title: String @@ -269,7 +269,7 @@ private final class CustomMenuCellDataSource: YoshiResuableCellDataSource { Then, provide the menu that conforms to `YoshiGenericMenu` referencing to the data source. ```swift -internal struct MenuWithCustomUI: YoshiGenericMenu { +struct MenuWithCustomUI: YoshiGenericMenu { var cellSource: YoshiResuableCellDataSource { return CustomMenuCellDataSource() diff --git a/Yoshi/QAKit/EnvironmentMenu/YoshiEnvironment.swift b/Yoshi/QAKit/EnvironmentMenu/YoshiEnvironment.swift index ca59618..ba6513a 100644 --- a/Yoshi/QAKit/EnvironmentMenu/YoshiEnvironment.swift +++ b/Yoshi/QAKit/EnvironmentMenu/YoshiEnvironment.swift @@ -8,7 +8,7 @@ import Foundation -internal func == (left: YoshiEnvironment, right: YoshiEnvironment) -> Bool { +func == (left: YoshiEnvironment, right: YoshiEnvironment) -> Bool { return left.baseURL == right.baseURL } diff --git a/Yoshi/QAKit/EnvironmentMenu/YoshiPersistentEnvironment.swift b/Yoshi/QAKit/EnvironmentMenu/YoshiPersistentEnvironment.swift index 203219e..1678bdb 100644 --- a/Yoshi/QAKit/EnvironmentMenu/YoshiPersistentEnvironment.swift +++ b/Yoshi/QAKit/EnvironmentMenu/YoshiPersistentEnvironment.swift @@ -9,7 +9,7 @@ import Foundation /// An class container used to help enum YoshiEnvironment encoding since enum encoding is not supported. -internal class YoshiPersistentEnvironment: Codable { +class YoshiPersistentEnvironment: Codable { /// Persisted Environment. private(set) var persistedEnvironment: T diff --git a/Yoshi/Yoshi.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/Yoshi/Yoshi.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist new file mode 100644 index 0000000..18d9810 --- /dev/null +++ b/Yoshi/Yoshi.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist @@ -0,0 +1,8 @@ + + + + + IDEDidComputeMac32BitWarning + + + diff --git a/Yoshi/Yoshi/Menus/YoshiDateSelectorMenu/YoshiDateSelectorMenuCellDataSource.swift b/Yoshi/Yoshi/Menus/YoshiDateSelectorMenu/YoshiDateSelectorMenuCellDataSource.swift index 1d583fb..e81cf22 100644 --- a/Yoshi/Yoshi/Menus/YoshiDateSelectorMenu/YoshiDateSelectorMenuCellDataSource.swift +++ b/Yoshi/Yoshi/Menus/YoshiDateSelectorMenu/YoshiDateSelectorMenuCellDataSource.swift @@ -7,7 +7,7 @@ // /// Cell data source defining the layout for YoshiDateSelectorMenu's cell -internal struct YoshiDateSelectorMenuCellDataSource: YoshiReusableCellDataSource { +struct YoshiDateSelectorMenuCellDataSource: YoshiReusableCellDataSource { private let title: String diff --git a/Yoshi/Yoshi/Menus/YoshiSingleSelectionMenu/YoshiSingleSelectionMenuItem.swift b/Yoshi/Yoshi/Menus/YoshiSingleSelectionMenu/YoshiSingleSelectionMenuItem.swift index 213048d..b31dee0 100644 --- a/Yoshi/Yoshi/Menus/YoshiSingleSelectionMenu/YoshiSingleSelectionMenuItem.swift +++ b/Yoshi/Yoshi/Menus/YoshiSingleSelectionMenu/YoshiSingleSelectionMenuItem.swift @@ -7,7 +7,7 @@ // /// Internal YoshiGenericMenu used for single selection menu. -internal final class YoshiSingleSelectionMenuItem: YoshiGenericMenu { +final class YoshiSingleSelectionMenuItem: YoshiGenericMenu { var title: String { return selection.title diff --git a/Yoshi/Yoshi/Menus/YoshiTableViewMenu/YoshiTableViewSubmenuItem.swift b/Yoshi/Yoshi/Menus/YoshiTableViewMenu/YoshiTableViewSubmenuItem.swift index 425d424..0680b98 100644 --- a/Yoshi/Yoshi/Menus/YoshiTableViewMenu/YoshiTableViewSubmenuItem.swift +++ b/Yoshi/Yoshi/Menus/YoshiTableViewMenu/YoshiTableViewSubmenuItem.swift @@ -8,7 +8,7 @@ /// Internal struct that map the YoshiTableViewMenuItem to a YoshiGenericMenu. /// This menu is interannly used to support YoshiTableViewMenu. -internal struct YoshiTableViewSubmenuItem: YoshiGenericMenu { +struct YoshiTableViewSubmenuItem: YoshiGenericMenu { let name: String let subtitle: String? diff --git a/Yoshi/Yoshi/Utility/AppBundleUtility.swift b/Yoshi/Yoshi/Utility/AppBundleUtility.swift index 321ca0b..3c4a311 100644 --- a/Yoshi/Yoshi/Utility/AppBundleUtility.swift +++ b/Yoshi/Yoshi/Utility/AppBundleUtility.swift @@ -7,7 +7,7 @@ // /// Utility for retrieving items from the App Bundle -internal class AppBundleUtility: NSObject { +class AppBundleUtility: NSObject { /** The application version + build number text. diff --git a/Yoshi/Yoshi/Utility/Color.swift b/Yoshi/Yoshi/Utility/Color.swift index de211c3..191b7ea 100644 --- a/Yoshi/Yoshi/Utility/Color.swift +++ b/Yoshi/Yoshi/Utility/Color.swift @@ -9,7 +9,7 @@ /** A color object */ -internal struct Color { +struct Color { /// The red value. let red: UInt8 diff --git a/Yoshi/Yoshi/View Controllers/Debug Date Picker View Controller/DebugDatePickerViewController.swift b/Yoshi/Yoshi/View Controllers/Debug Date Picker View Controller/DebugDatePickerViewController.swift index fe9d4b1..eb43627 100644 --- a/Yoshi/Yoshi/View Controllers/Debug Date Picker View Controller/DebugDatePickerViewController.swift +++ b/Yoshi/Yoshi/View Controllers/Debug Date Picker View Controller/DebugDatePickerViewController.swift @@ -7,7 +7,7 @@ // /// The date picker view controller. -internal class DebugDatePickerViewController: UIViewController { +class DebugDatePickerViewController: UIViewController { private var selectorMenu: YoshiDateSelectorMenu? diff --git a/Yoshi/Yoshi/View Controllers/Debug View Controller/DebugViewController.swift b/Yoshi/Yoshi/View Controllers/Debug View Controller/DebugViewController.swift index 1ed6a2b..cc83e15 100644 --- a/Yoshi/Yoshi/View Controllers/Debug View Controller/DebugViewController.swift +++ b/Yoshi/Yoshi/View Controllers/Debug View Controller/DebugViewController.swift @@ -6,10 +6,10 @@ // Copyright © 2016 Prolific Interactive. All rights reserved. // -internal typealias VoidCompletionBlock = () -> Void +typealias VoidCompletionBlock = () -> Void /// A debug menu. -internal final class DebugViewController: UIViewController { +final class DebugViewController: UIViewController { var completionHandler: ((_ completed: VoidCompletionBlock? ) -> Void)? diff --git a/Yoshi/Yoshi/YoshiConfigurationManager.swift b/Yoshi/Yoshi/YoshiConfigurationManager.swift index ee9c09d..182278e 100644 --- a/Yoshi/Yoshi/YoshiConfigurationManager.swift +++ b/Yoshi/Yoshi/YoshiConfigurationManager.swift @@ -7,7 +7,7 @@ // /// The configuration manager for the debug menu. -internal final class YoshiConfigurationManager { +final class YoshiConfigurationManager { /// The default instance. static let sharedInstance = YoshiConfigurationManager()