Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-node-exporter] Prevent node exporter from being scheduled on fargate #4735

Open
mariuskimmina opened this issue Jul 24, 2024 · 1 comment · May be fixed by #4736
Open

[prometheus-node-exporter] Prevent node exporter from being scheduled on fargate #4735

mariuskimmina opened this issue Jul 24, 2024 · 1 comment · May be fixed by #4736
Labels
enhancement New feature or request

Comments

@mariuskimmina
Copy link

mariuskimmina commented Jul 24, 2024

Is your feature request related to a problem ?

When running on EKS clusters with a mix of fargate and EC2 nodes the node exporter pods can end up unschedulable and stuck in a pending state.

Describe the solution you'd like.

Add a nodeAffinity to the node-exporter by default

  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchExpressions:
          - key: eks.amazonaws.com/compute-type
            operator: NotIn
            values:
            - fargate

Describe alternatives you've considered.

None

Additional context.

There have been many previous Issues about this:

#2876
#2908
#925

Grafanas k8s-monitoring charts have also added a node affinity to the node-exporter by default which prevents it from running on fargate - see grafana/k8s-monitoring-helm#362.
I think it would be useful to do the same here.

If my understanding is correct, then for people that have already added this nodeAffinity this would not be a breaking change, it would simply be redundant - but this I am not completely sure about.

@mariuskimmina mariuskimmina added the enhancement New feature or request label Jul 24, 2024
@mariuskimmina mariuskimmina changed the title [prometheus-node-exporter] Prevent node exporter from running on fargate [prometheus-node-exporter] Prevent node exporter from being scheduled on fargate Jul 24, 2024
@MedAzizTousli
Copy link

I have a pending Node Exporter pod that is scheduled on a Fargate node, and it has been bothering me a lot. +1 for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants