Overriding kube-rbac-proxy container image?

[AshleyDumaine]

Hey, I'm trying to upgrade my version of kube-prometheus (out of date by a few months) but am hitting issues trying to use a different image repo for kube-rbac-proxy (used by node-exporter, kube-state-metrics, and prometheus-operator). What I had before the refactor that worked:

    _config+:: {
      versions+:: {
          kubeRbacProxy: '<version>',
      },

      imageRepos+:: {
          kubeRbacProxy: '{{ image_repo }}/kube-prometheus/kube-rbac-proxy',
      },

What I'm trying to do after with the migration changes that doesn't work:

    values+:: {
      common+: {
        versions: {
          kubeRbacProxy: '<version>',
        },
        images: {
          kubeRbacProxy: '{{ image_repo }}/kube-prometheus/kube-rbac-proxy:' + $.values.common.versions.kubeRbacProxy
        },
      },

There doesn't seem to be a straightforward way to override this like the other images (alertmanager, kubeStateMetrics, nodeExporter, etc). I'm not seeing any examples in the repo that showcase how to override this specific container image either. How should this be done nowadays? I was also wondering if we'd be open to something like this to make configuring the image override easier:

--- a/jsonnet/kube-prometheus/main.libsonnet
+++ b/jsonnet/kube-prometheus/main.libsonnet
@@ -28,6 +28,7 @@ local prometheus = import './components/prometheus.libsonnet';
         prometheus: error 'must provide version',
         prometheusAdapter: error 'must provide version',
         prometheusOperator: error 'must provide version',
+        kubeRbacProxy: error 'must provide version',
       } + (import 'versions.json'),
       images: {
         alertmanager: 'quay.io/prometheus/alertmanager:v' + $.values.common.versions.alertmanager,
@@ -39,6 +40,7 @@ local prometheus = import './components/prometheus.libsonnet';
         prometheusAdapter: 'directxman12/k8s-prometheus-adapter:v' + $.values.common.versions.prometheusAdapter,
         prometheusOperator: 'quay.io/prometheus-operator/prometheus-operator:v' + $.values.common.versions.prometheusOperator,
         prometheusOperatorReloader: 'quay.io/prometheus-operator/prometheus-config-reloader:v' + $.values.common.versions.prometheusOperator,
+        kubeRbacProxy: 'quay.io/brancz/kube-rbac-proxy:v' + $.values.common.versions.kubeRbacProxy,
       },
     },
     alertmanager: {
@@ -52,6 +54,7 @@ local prometheus = import './components/prometheus.libsonnet';
       namespace: $.values.common.namespace,
       version: $.values.common.versions.blackboxExporter,
       image: $.values.common.images.blackboxExporter,
+      krpImage: $.values.common.images.kubeRbacProxy,
     },
     grafana: {
       namespace: $.values.common.namespace,
@@ -65,12 +68,14 @@ local prometheus = import './components/prometheus.libsonnet';
       namespace: $.values.common.namespace,
       version: $.values.common.versions.kubeStateMetrics,
       image: $.values.common.images.kubeStateMetrics,
+      krpImage: $.values.common.images.kubeRbacProxy,
       mixin+: { ruleLabels: $.values.common.ruleLabels },
     },
     nodeExporter: {
       namespace: $.values.common.namespace,
       version: $.values.common.versions.nodeExporter,
       image: $.values.common.images.nodeExporter,
+      krpImage: $.values.common.images.kubeRbacProxy,
       mixin+: { ruleLabels: $.values.common.ruleLabels },
     },
     prometheus: {
@@ -91,6 +96,7 @@ local prometheus = import './components/prometheus.libsonnet';
       namespace: $.values.common.namespace,
       version: $.values.common.versions.prometheusOperator,
       image: $.values.common.images.prometheusOperator,
+      krpImage: $.values.common.images.kubeRbacProxy,
       configReloaderImage: $.values.common.images.prometheusOperatorReloader,
       commonLabels+: {
         'app.kubernetes.io/part-of': 'kube-prometheus',

I thought it might make sense since we can already override the prometheus-operator's configReloaderImage this way.

[lpugoy]

You need the commits related to this issue: #1110. If you're using 0.8 it's not included there.