Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrra: Pass labels to merge via values common objects #2547

Open
metalmatze opened this issue Nov 8, 2024 · 0 comments
Open

pyrra: Pass labels to merge via values common objects #2547

metalmatze opened this issue Nov 8, 2024 · 0 comments

Comments

@metalmatze
Copy link
Member

The Pyrra addon should be able to get a common labels object passed and then pick that one up for all SLOs that are part of its addon.
I'm migrating its SLOs to the Thanos Ruler and I'm doing this:

      'slo-apiserver-read-response-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-apiserver-write-response-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-kubelet-request-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-notification-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-operator-http-errors':{ metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-operator-reconcile-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-query-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-rule-evaluation-failures': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },
      'slo-prometheus-sd-kubernetes-errors': { metadata+: { labels+: { prometheus: 'thanos-k8s' } } },

Instead we should allow to pass the labels once and then pick those labels up via the values common object.


labels: {
prometheus: 'k8s',
role: 'alert-rules',
},

cc @kakkoyun for potential contribution or improvement when making Pyrra a core component next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant