You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While investigating and fixing #1584 I noticed some tech-debt build up over time:
func (c *processCollector) Describe(ch chan<- *Desc) { is always the same despite on different platforms we don't expect certain metrics. Perhaps to move per platform?
We have noop files for wasip1 and js, but for darwin (mac) we simply use "other" file and error out in silent way (if Errors is equal to false). Let's make it consistent and either error all of them silently (and verbosely if Errors == true), or have all of them noop. This is reflected by inconsistency in prod files build tags and test file build tags.
While investigating and fixing #1584 I noticed some tech-debt build up over time:
func (c *processCollector) Describe(ch chan<- *Desc) {
is always the same despite on different platforms we don't expect certain metrics. Perhaps to move per platform?build
tags and test filebuild
tags.Description
. This is to ensure we don't hit collected metric process_network_receive_bytes_total counter with unregistered descriptor #1584 again. Some ideas:Description
method?Acceptance Criteria
Also, added issue for implementing those for darwin: #1590
The text was updated successfully, but these errors were encountered: