Issue #50: ARM64 static compilation fails with linking errors

proofrock · proofrock · commit 9531f1a8ef63 · 2025-01-26T19:37:48.000+01:00
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -6,8 +6,8 @@ on:
       - "v*"
 
 env:
-  GO_VERSION: "1.23.4"
-  REGISTRY_IMAGE: "ghcr.io/proofrock/ws4sql"
+  GO_VERSION: "1.23.5"
+  REGISTRY_IMAGE: "ghcr.io/proofrock/ws4sql_test"
 
 jobs:
   test:
@@ -31,22 +31,24 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env.GO_VERSION }}
-
       - name: Modify version number
         run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
         working-directory: src/
 
       - name: Build dir generation
         run: mkdir bin/
 
+      - name: Setup Alpine chroot
+        uses: jirutka/setup-alpine@v1
+        with:
+          branch: edge
+
       - name: Compile and Pack Artifact
         run: |
-          make build-static
+          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd
+          make build-static-linux-musl-amd64
           tar czf bin/ws4sql-${{ github.ref_name }}-linux-amd64.tar.gz -C bin/ ws4sql
-          rm bin/ws4sql
+        shell: alpine.sh --root {0}
 
       - name: Upload artifacts
         uses: actions/upload-artifact@v4
@@ -55,7 +57,39 @@ jobs:
           path: bin/ws4sql-${{ github.ref_name }}-linux-amd64.tar.gz
           retention-days: 1
 
-  # TODO build_linux_arm64
+  build_linux_arm64:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Modify version number
+        run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
+        working-directory: src/
+
+      - name: Build dir generation
+        run: mkdir bin/
+
+      - name: Setup Alpine chroot
+        uses: jirutka/setup-alpine@v1
+        with:
+          arch: aarch64
+          branch: edge
+
+      - name: Compile and Pack Artifact
+        run: |
+          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd
+          make build-static-linux-musl-arm64
+          tar czf bin/ws4sql-${{ github.ref_name }}-linux-arm64.tar.gz -C bin/ ws4sql
+        shell: alpine.sh --root {0}
+
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: binary_linux_arm64
+          path: bin/ws4sql-${{ github.ref_name }}-linux-arm64.tar.gz
+          retention-days: 1
 
   build_macos_arm64:
     runs-on: macos-latest
@@ -122,28 +156,111 @@ jobs:
           path: bin/ws4sql-${{ github.ref_name }}-win-amd64.zip
           retention-days: 1
 
+  build_docker:
+    needs:
+      - build_linux_amd64
+      - build_linux_arm64
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        platform:
+          - linux/amd64
+          - linux/arm64
+    steps:
+      - name: Prepare
+        run: |
+          platform=${{ matrix.platform }}
+          echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
+          echo "PLATFORM_PAIR_UNDERSCORE=${platform//\//_}" >> $GITHUB_ENV
+
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Download artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: binary_${{ env.PLATFORM_PAIR_UNDERSCORE }}
+          path: bin/
+
+      - name: Unpack artifact
+        run: |
+          tar xzf *.tar.gz
+          chmod +x ws4sql # Probably unnecessary
+        working-directory: bin/
+
+      - name: Docker meta
+        id: meta
+        uses: docker/metadata-action@v5
+        with:
+          images: ${{ env.REGISTRY_IMAGE }}
+
+      # - name: Set up QEMU
+      #   uses: docker/setup-qemu-action@v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Login to Github Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.TOKEN }}
+
+      - name: Build and push by digest
+        id: build
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          platforms: ${{ matrix.platform }}
+          labels: ${{ steps.meta.outputs.labels }}
+          outputs: type=image,name=${{ env.REGISTRY_IMAGE }},push-by-digest=true,name-canonical=true,push=true
+
+      - name: Export digest
+        run: |
+          mkdir -p /tmp/digests
+          digest="${{ steps.build.outputs.digest }}"
+          touch "/tmp/digests/${digest#sha256:}"
+
+      - name: Upload digest
+        uses: actions/upload-artifact@v4
+        with:
+          name: digests-${{ env.PLATFORM_PAIR }}
+          path: /tmp/digests/*
+          if-no-files-found: error
+          retention-days: 1
+
   release:
     needs:
       - build_linux_amd64
+      - build_linux_arm64
       - build_macos_arm64
       - build_win_amd64
+      - build_docker
       - test
     runs-on: ubuntu-latest
 
     steps:
-      - name: Download artifacts [1/3]
+      - name: Download artifacts [1/4]
         uses: actions/download-artifact@v4
         with:
           name: binary_linux_amd64
           path: bin/
 
-      - name: Download artifacts [2/3]
+      - name: Download artifacts [2/4]
+        uses: actions/download-artifact@v4
+        with:
+          name: binary_linux_arm64
+          path: bin/
+
+      - name: Download artifacts [3/4]
         uses: actions/download-artifact@v4
         with:
           name: binary_macos_arm64
           path: bin/
 
-      - name: Download artifacts [3/3]
+      - name: Download artifacts [4/4]
         uses: actions/download-artifact@v4
         with:
           name: binary_win_amd64
@@ -174,6 +291,16 @@ jobs:
           asset_name: ws4sql-${{ github.ref_name }}-linux-amd64.tar.gz
           asset_content_type: application/gzip
 
+      - name: Release Artifact [linux/arm64]
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.TOKEN }}
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: bin/ws4sql-${{ github.ref_name }}-linux-arm64.tar.gz
+          asset_name: ws4sql-${{ github.ref_name }}-linux-arm64.tar.gz
+          asset_content_type: application/gzip
+
       - name: Release Artifact [darwin/arm64]
         uses: actions/upload-release-asset@v1
         env:
@@ -194,73 +321,10 @@ jobs:
           asset_name: ws4sql-${{ github.ref_name }}-win-amd64.zip
           asset_content_type: application/zip
 
-  build-docker:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        platform:
-          - linux/amd64
-          - linux/arm64
-    steps:
-      - name: Prepare
-        run: |
-          platform=${{ matrix.platform }}
-          echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
-
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Modify version number
-        run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
-      - name: Docker meta
-        id: meta
-        uses: docker/metadata-action@v5
-        with:
-          images: ${{ env.REGISTRY_IMAGE }}
-
-      # - name: Set up QEMU
-      #   uses: docker/setup-qemu-action@v3
-
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-
-      - name: Login to Github Container Registry
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.TOKEN }}
-
-      - name: Build and push by digest
-        id: build
-        uses: docker/build-push-action@v5
-        with:
-          context: .
-          platforms: ${{ matrix.platform }}
-          labels: ${{ steps.meta.outputs.labels }}
-          outputs: type=image,name=${{ env.REGISTRY_IMAGE }},push-by-digest=true,name-canonical=true,push=true
-
-      - name: Export digest
-        run: |
-          mkdir -p /tmp/digests
-          digest="${{ steps.build.outputs.digest }}"
-          touch "/tmp/digests/${digest#sha256:}"
-
-      - name: Upload digest
-        uses: actions/upload-artifact@v4
-        with:
-          name: digests-${{ env.PLATFORM_PAIR }}
-          path: /tmp/digests/*
-          if-no-files-found: error
-          retention-days: 1
-
-  merge-docker:
+  merge_docker:
     runs-on: ubuntu-latest
     needs:
-      - build-docker
+      - build_docker
       - release
       - test
     steps:
diff --git a/.gitignore b/.gitignore
@@ -5,6 +5,7 @@ bin/
 /notes.md
 test/*.db
 test/*.db.wal
+libduckdb_bundle.a
 
 # Created by https://www.toptal.com/developers/gitignore/api/go,macos,linux,windows
 # Edit at https://www.toptal.com/developers/gitignore?templates=go,macos,linux,windows
diff --git a/Dockerfile b/Dockerfile
@@ -1,15 +1,6 @@
-# See BUILDING.md
+FROM gcr.io/distroless/static-debian12
 
-FROM golang:latest AS build
-
-WORKDIR /go/src/app
-COPY . .
-
-RUN make build
-
-# Now copy it into our base image.
-FROM debian:12-slim
-COPY --from=build /go/src/app/bin/ws4sql /
+COPY bin/ws4sql /
 
 EXPOSE 12321
 VOLUME /data
diff --git a/Makefile b/Makefile
@@ -28,6 +28,24 @@ build-static:
 	cd src; go build -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension" -ldflags='-w -extldflags "-static"'
 	mv src/ws4sql bin/
 
+build-static-linux-musl-amd64:
+	# In an Alpine Linux context with the following packages
+	#   musl-dev go g++ make openssl openssl-dev openssl-libs-static zstd
+	make build-prepare
+	cp precompiled/libduckdb_bundle/linux-musl-amd64/libduckdb_bundle.a.zst src/
+	cd src && zstd -d libduckdb_bundle.a.zst
+	cd src && CGO_CFLAGS="-O2 -fPIC" CGO_CXXFLAGS="-O2 -fPIC" CGO_LDFLAGS="-lduckdb_bundle -lssl -lcrypto -L./" go build -buildvcs=false -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension duckdb_use_static_lib" -ldflags='-w -extldflags "-static"'
+	mv src/ws4sql bin/
+
+build-static-linux-musl-arm64:
+	# In an Alpine Linux context with the following packages
+	#   musl-dev go g++ make openssl openssl-dev openssl-libs-static zstd
+	make build-prepare
+	cp precompiled/libduckdb_bundle/linux-musl-arm64/libduckdb_bundle.a.zst src/
+	cd src && zstd -d libduckdb_bundle.a.zst
+	cd src && CGO_CFLAGS="-O2 -fPIC" CGO_CXXFLAGS="-O2 -fPIC" CGO_LDFLAGS="-lduckdb_bundle -lssl -lcrypto -L./" go build -buildvcs=false -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension duckdb_use_static_lib" -ldflags='-w -extldflags "-static"'
+	mv src/ws4sql bin/
+
 test:
 	cd src; go test -v -timeout 6m
 
diff --git a/precompiled/libduckdb_bundle/BUILDING.md b/precompiled/libduckdb_bundle/BUILDING.md
@@ -0,0 +1,12 @@
+# Linux
+
+To compile this prerequisite, set up an Alpine Linux (edge), for example in docker - and use this broad "recipe":
+
+```bash
+apk add --no-cache findutils musl-dev go g++ git make cmake ninja openssl openssl-dev openssl-libs-static python3 zstd
+git clone -b "v1.1.3" https://github.com/duckdb/duckdb
+cd duckdb
+CFLAGS="-O3 -fPIC" CXXFLAGS="-O3 -fPIC" BUILD_SHELL=0 BUILD_UNITTESTS=0 DUCKDB_PLATFORM=any ENABLE_EXTENSION_AUTOLOADING=1 ENABLE_EXTENSION_AUTOINSTALL=1 BUILD_EXTENSIONS="json;httpfs;parquet" make bundle-library -j4
+cp duckdb/build/release/libduckdb_bundle.a .
+zstd -T4 -19 duckdb/build/release/libduckdb_bundle.a
+```
diff --git a/precompiled/libduckdb_bundle/linux-musl-amd64/libduckdb_bundle.a.zst b/precompiled/libduckdb_bundle/linux-musl-amd64/libduckdb_bundle.a.zst
diff --git a/precompiled/libduckdb_bundle/linux-musl-arm64/libduckdb_bundle.a.zst b/precompiled/libduckdb_bundle/linux-musl-arm64/libduckdb_bundle.a.zst
diff --git a/src/ws4sql.go b/src/ws4sql.go
@@ -38,7 +38,7 @@ import (
 	_ "github.com/mattn/go-sqlite3"
 )
 
-const version = "ws4sql-v0.0.0"
+const version = "v0.0.0"
 
 // Simply prints a header, parses the cli parameters and calls
 // launch(), that is the real entry point. It's separate from the

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ import (`
`38`	`38`	`_ "github.com/mattn/go-sqlite3"`
`39`	`39`	`)`
`40`	`40`
`41`		`-const version = "ws4sql-v0.0.0"`
	`41`	`+const version = "v0.0.0"`
`42`	`42`
`43`	`43`	`// Simply prints a header, parses the cli parameters and calls`
`44`	`44`	`// launch(), that is the real entry point. It's separate from the`