Update detector

Author: forgetso

packages/provider/src/api/captcha.ts

@@ -43,7 +43,7 @@ import { getIPAddress } from "../util.js";
 import { handleErrors } from "./errorHandler.js";
 
 const DEFAULT_FRICTIONLESS_THRESHOLD = 0.5;
-const TEN_MINUTES = 60 * 10;
+const TEN_MINUTES = 60 * 10 * 1000;
 
 /**
  * Returns a router connected to the database which can interact with the Proposo protocol
@@ -456,6 +456,7 @@ export function prosopoRouter(env: ProviderEnvironment): Router {
 				// Check if the token has already been used
 				const isTokenUsed = await tasks.db.checkFrictionlessTokenRecord(token);
 				if (isTokenUsed) {
+					tasks.logger.info("Token has already been used");
 					return res.json(tasks.frictionlessManager.sendImageCaptcha());
 				}
 
@@ -467,6 +468,10 @@ export function prosopoRouter(env: ProviderEnvironment): Router {
 
 				// If the timestamp is older than 10 minutes, send an image captcha
 				if (timestamp < Date.now() - TEN_MINUTES) {
+					tasks.logger.info(
+						"Timestamp is older than 10 minutes",
+						new Date(timestamp),
+					);
 					return res.json(tasks.frictionlessManager.sendImageCaptcha());
 				}
 

packages/provider/src/tasks/detection/decodePayload.js

@@ -17,9 +17,12 @@ import getBotScoreFromPayload from "./decodePayload.js";
 export const getBotScore = async (payload: string) => {
 	const logger = getLogger(LogLevel.enum.info, "provider.get_bot_score");
 	try {
-		const result = await getBotScoreFromPayload(payload);
-		const baseBotScore: number = result[0];
-		const timestamp: number = result[1];
+		const result = (await getBotScoreFromPayload(payload)) as {
+			score: number;
+			timestamp: number;
+		};
+		const baseBotScore: number = result.score;
+		const timestamp: number = result.timestamp;
 
 		if (baseBotScore === undefined) {
 			return { baseBotScore: 1, timestamp: 0 };

packages/provider/src/tasks/detection/getBotScore.ts

@@ -53,11 +53,13 @@ export class FrictionlessManager {
 		ipAddress: Address4 | Address6,
 		dapp: string,
 	): Promise<boolean> {
-		return !!(await checkIpRules(this.db, ipAddress, dapp));
+		const rule = await checkIpRules(this.db, ipAddress, dapp);
+		return !!rule;
 	}
 
 	async checkUserRules(user: string, dapp: string): Promise<boolean> {
-		return !!(await checkUserRules(this.db, user, dapp));
+		const rule = await checkUserRules(this.db, user, dapp);
+		return !!rule;
 	}
 
 	checkLangRules(acceptLanguage: string): number {