Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove regex hacks for typechain #807

Closed
goastler opened this issue Nov 16, 2023 · 4 comments
Closed

remove regex hacks for typechain #807

goastler opened this issue Nov 16, 2023 · 4 comments
Milestone
Launch on a mainnet

Comments

@goastler
Copy link
Member

No description provided.

@goastler goastler added this to the Launch on a mainnet milestone Nov 16, 2023
@goastler
Copy link
Member Author

we have various hacks for adding bits to the typechain output via regex find-and-replace. We should remove these in favour of making the change in typechain directly

@HughParry
Copy link
Contributor

What is the status of typechain problems like this?

@HughParry
Copy link
Contributor

@forgetso Please add this under the epic for typechain proposal

@HughParry
Copy link
Contributor

^^^ Refinement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Launch on a mainnet
Development

No branches or pull requests
2 participants
@goastler @HughParry