Trouble setting volume dynamically

[EpiEndless]

Hi,
I have just started using arduino-audio-tools with ESP32 DevkitC - thanks for providing this great library.

The following code started as the streams-sd_mp3-i2s.ino example, modified to use SPIFFS instead of SD card, and to add volume control. An initial mp3 is played, and then in the loop(), a further mp3 is played 5 times as expected, all at the requested volume.

However, if I uncomment the "setVolume()" command in the loop, the ESP32 reboots after this message:
assert failed: T& audio_tools::Vector::operator [with T = float] Vector.h:257 (index < len)

Apparently I don't know how to change the volume dynamically.
Can anyone put me on the correct track here, please?

#define FORMAT_SPIFFS_IF_FAILED false

#include "FS.h"
#include "SPIFFS.h"
#include "AudioTools.h"
#include "AudioTools/AudioCodecs/CodecMP3Helix.h"

const int chipSelect=10;
I2SStream i2s; // final output of decoded stream
VolumeStream volume(i2s);
EncodedAudioStream decoder(&volume, new MP3DecoderHelix()); // Decoding stream
StreamCopy copier;
File audioFile;

int vol;

void setup(){
Serial.begin(115200);
AudioToolsLogger.begin(Serial, AudioToolsLogLevel::Warning);

// setup file
Serial.begin(115200);
if (!SPIFFS.begin(FORMAT_SPIFFS_IF_FAILED)) {
Serial.println("SPIFFS Mount Failed");
return;
}

audioFile = SPIFFS.open("/02 Garage door.mp3");

// setup i2s
auto config = i2s.defaultConfig(TX_MODE);
i2s.begin(config);

// set initial volume
auto vcfg = volume.defaultConfig();
vcfg.copyFrom(config);
//vcfg.allow_boost = true; // activate amplification using linear control
volume.begin(vcfg); // we need to provide the bits_per_sample and channels
volume.setVolume(1.0);

// setup I2S based on sampling rate provided by decoder
decoder.begin();

// begin copy
copier.begin(decoder, audioFile);

vol = 2;
}

void loop(){
if (!copier.copy()) {
if(vol > 10) stop();
else{
delay(200);
//volume.setVolume(0.5);
vol+=2;
audioFile.close();
audioFile = SPIFFS.open("/01 startup.mp3");
copier.begin(decoder, audioFile);
}
}
}

[pschatzmann]

Use the log level info (or debug) to figure out what is happening...
Provide the backtrace to find out what code path is causing this.

Somehow you access a vector at a position that does not exist. Maybe this is related to a changing number of channels ?

ps. I committed a correction, but I am not sure if it covers your special case w/o having further details...

[EpiEndless]

Hi, sorry or delay in replying. I have more information.
I can crash the program in setup:
volume.begin(vcfg); // we need to provide the bits_per_sample and channels
volume.setVolume(1);
volume.setVolume(0.75);

decoder.begin();
volume.setVolume(0.5);

The volume() call after decoder.begin() crashes:
[E] Allocator.h : 108 - allocateation failed for 218764 bytes

Now I have checked, and during the earlier calls to volume(), the channel count info.channels, which is used in volume(), is 2.
After decoder.begin() the channel count is a large number which varies, such as 54691.

The log below seems to show the audio setting change after decoder.begin().

[D] Allocator.h : 76 - Allocated 8
[D] Allocator.h : 76 - Allocated 8
[I] VolumeStream.h : 200 - setVolume: 1.000000 at 0
[I] VolumeStream.h : 200 - setVolume: 1.000000 at 1
[I] VolumeStream.h : 183 - RGS setVolume: 1.000000 2 <- I added this to show the channel count is 2
[I] VolumeStream.h : 183 - RGS setVolume: 0.750000 2
[I] VolumeStream.h : 200 - setVolume: 0.750000 at 0
[I] VolumeStream.h : 200 - setVolume: 0.750000 at 1
[D] AudioIO.h : 30 - void audio_tools::TransformationReader::begin(T*, Stream*) [with T = audio_tools::ReformatBaseStream]
[D] AudioEncoded.h : 150 - virtual bool audio_tools::EncodedAudioOutput::begin()
[D] AudioEncoded.h : 152 - virtual bool audio_tools::EncodedAudioOutput::begin()
[D] CodecMP3Helix.h : 128 - virtual void audio_tools::MP3DecoderHelix::addNotifyAudioChange(audio_tools::AudioInfoSupport&)
[D] AudioCodecsBase.h : 29 - virtual void audio_tools::AudioDecoder::setAudioInfo(audio_tools::AudioInfo)
[D] VolumeStream.h : 166 - virtual void audio_tools::VolumeStream::setAudioInfo(audio_tools::AudioInfo)
[I] I2SStream.h : 96 - virtual void audio_tools::I2SStream::setAudioInfo(audio_tools::AudioInfo)
[D] BaseStream.h : 131 - virtual void audio_tools::AudioStream::setAudioInfo(audio_tools::AudioInfo)
[I] AudioTypes.h : 124 - in: sample_rate: 1137237907 / channels: 54691 / bits_per_sample: 154
[I] AudioTypes.h : 124 - out: sample_rate: 1137237907 / channels: 54691 / bits_per_sample: 154
[I] I2SStream.h : 105 - restarting i2s
[I] AudioTypes.h : 124 - I2SStream sample_rate: 1137237907 / channels: 54691 / bits_per_sample: 154
[D] I2SESP32V1.h : 86 - void audio_tools::I2SDriverESP32V1::end()
[D] I2SESP32V1.h : 57 - bool audio_tools::I2SDriverESP32V1::begin(audio_tools::I2SConfigESP32V1)
[D] I2SESP32V1.h : 541 - bool audio_tools::I2SDriverESP32V1::begin(audio_tools::I2SConfigESP32V1, int, int)
[I] AudioTypes.h : 124 - sample_rate: 1137237907 / channels: 54691 / bits_per_sample: 154
[I] I2SConfigESP32V1.h : 78 - rx/tx mode: TX_MODE
[I] I2SConfigESP32V1.h : 79 - port_no: 0
[I] I2SConfigESP32V1.h : 80 - is_master: Master
[I] I2SConfigESP32V1.h : 81 - sample rate: 1137237907
[I] I2SConfigESP32V1.h : 82 - bits per sample: 154
[I] I2SConfigESP32V1.h : 83 - number of channels: 54691
[I] I2SConfigESP32V1.h : 84 - signal_type: Digital
[I] I2SConfigESP32V1.h : 85 - buffer_count:6
[I] I2SConfigESP32V1.h : 86 - buffer_size:512
[I] I2SConfigESP32V1.h : 87 - auto_clear: true
[I] I2SConfigESP32V1.h : 89 - i2s_format: I2S_STD_FORMAT
[I] I2SConfigESP32V1.h : 101 - pin_bck: 14
[I] I2SConfigESP32V1.h : 104 - pin_ws: 15
[I] I2SConfigESP32V1.h : 107 - pin_data: 22
[E] I2SESP32V1.h : 545 - invalid channels: 54691
[I] CodecMP3Helix.h : 82 - virtual bool audio_tools::MP3DecoderHelix::begin()
[I] VolumeStream.h : 183 - RGS setVolume: 0.500000 54691
[E] Allocator.h : 108 - allocateation failed for 218764 bytes

[pschatzmann]

Hmm, this does not make any sense: it seems that you send some non mp3 data to an mp3 decoder!
I have never seen something so completely wrong:
[I] AudioTypes.h : 124 - in: sample_rate: 1137237907 / channels: 54691 / bits_per_sample: 154

[pschatzmann]

Take it back, I can reproduce your isse...