Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justl comint formatting #75

Open
tsujp opened this issue Jan 28, 2025 · 3 comments
Open

Justl comint formatting #75

tsujp opened this issue Jan 28, 2025 · 3 comments

Comments

@tsujp
Copy link

tsujp commented Jan 28, 2025

The just compilation buffer does not setup things like links, syntax highlighting and so forth in the same way as comint and compilation mode do e.g. via project-compile.

It'd be nice to have these features still so clicking on links, navigating to and from compilation errors etc would still be possible when using just to execute compilation commands.

@tsujp
Copy link
Author

tsujp commented Jan 29, 2025

So it's probably these lines here right?

https://github.com/psibi/justl.el/blob/master/justl.el#L349-L355

If so I understand why since people can and do use Just to run much more than simple templates or aliases to build commands but people (like me) also do use Just to run or template build commands and in those cases I want compilation-mode features like error regexp matching and integration.

I'm not sure what the best compromise here is. If that is the offending location maybe we need a way to let justl.el know that a particular Just recipe it's invoking is one where we want to keep compilation-mode features, and in that case while executing the process and accepting buffer input it should keep the compilation-mode regexps. In all other cases it should remove them (as it currently does).

People who have custom compilation-mode regexps might want theirs also, so some general way to mark a recipe as using XYZ recipes for the duration of that recipe would solve this I think. I'm not sure how to best approach that. For now I'll have to keep using compilation-mode instead for compile commands because I need that integration.

@psibi
Copy link
Owner

psibi commented Feb 3, 2025

How will just's compilation buffer will know that the recipe needs to invoke a compilation buffer of specific major mode ?

@tsujp
Copy link
Author

tsujp commented Feb 5, 2025

I'm not sure what the best approach is for that at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants