Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ddg bangs in storage.local #41

Open
kelszo opened this issue Aug 9, 2023 · 1 comment
Open

Store ddg bangs in storage.local #41

kelszo opened this issue Aug 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kelszo
Copy link

kelszo commented Aug 9, 2023

The current limit for storage.local is 5MB for Firefox and 10MB for Chrome. With these limits it should be possible to store all ddg bangs by default in storage.local. One would package a ddg-all.json (currently 1.7MB, thus fitting in the storage.local quota) with the plugin and on installation/setup load these into storage.local.

On usage, the plugin would then first search for custom bangs in storage.sync, if none are found do a lookup in storage.local (i.e. all ddg bangs packaged by default). An option could be provided to not fall back onto the ddg bangs in storage.local.

Additionally, if that is not enough storage for some reason one could use the unlimitedstorage permission (available in both Firefox and Chrome).

@psidex
Copy link
Owner

psidex commented Aug 10, 2023

Hi, thanks for raising, definetly something I want to look into doing.

Just to note, there's been some discussion about an idea like this in #38 here.

@psidex psidex added the enhancement New feature or request label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants