From 871ef0c56412b71ca43602759ee0caff68e32fdf Mon Sep 17 00:00:00 2001 From: Matthew Penner Date: Fri, 14 Feb 2025 13:22:59 -0700 Subject: [PATCH] fix: EnvironmentWriterTrait not allowing null values Fixes https://github.com/pterodactyl/panel/issues/5108 Signed-off-by: Matthew Penner --- app/Traits/Commands/EnvironmentWriterTrait.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/Traits/Commands/EnvironmentWriterTrait.php b/app/Traits/Commands/EnvironmentWriterTrait.php index 533ec2aa32..8d6681623a 100644 --- a/app/Traits/Commands/EnvironmentWriterTrait.php +++ b/app/Traits/Commands/EnvironmentWriterTrait.php @@ -11,8 +11,12 @@ trait EnvironmentWriterTrait * reasonably cause environment parsing issues. Those values are then wrapped * in quotes before being returned. */ - public function escapeEnvironmentValue(string $value): string + public function escapeEnvironmentValue(?string $value): string { + if (is_null($value)) { + return ''; + } + if (!preg_match('/^\"(.*)\"$/', $value) && preg_match('/([^\w.\-+\/])+/', $value)) { return sprintf('"%s"', addslashes($value)); }