diff --git a/src/custommem.c b/src/custommem.c index 0da20c1340..a87ac1e9bb 100644 --- a/src/custommem.c +++ b/src/custommem.c @@ -150,7 +150,7 @@ static size_t getMaxFreeBlock(void* block, size_t block_size, void* start) // get start of block if(start) { blockmark_t *m = (blockmark_t*)start; - int maxsize = 0; + unsigned int maxsize = 0; while(m->next.x32) { // while there is a subblock if(!m->next.fill && m->next.size>maxsize) { maxsize = m->next.size; @@ -160,7 +160,7 @@ static size_t getMaxFreeBlock(void* block, size_t block_size, void* start) return (maxsize>=sizeof(blockmark_t))?maxsize:0; } else { blockmark_t *m = LAST_BLOCK(block, block_size); // start with the end - int maxsize = 0; + unsigned int maxsize = 0; while(m->prev.x32) { // while there is a subblock if(!m->prev.fill && m->prev.size>maxsize) { maxsize = m->prev.size; @@ -1505,7 +1505,7 @@ void reserveHighMem() if(!p || p[0]=='0') #endif return; // don't reserve by default - intptr_t cur = 1LL<<47; + uintptr_t cur = 1ULL<<47; mapmem_t* m = mapallmem; while(m && (m->endnext; diff --git a/src/elfs/elfdwarf_private.c b/src/elfs/elfdwarf_private.c index 90316a34b9..ed954e3522 100644 --- a/src/elfs/elfdwarf_private.c +++ b/src/elfs/elfdwarf_private.c @@ -579,7 +579,7 @@ uintptr_t get_parent_registers(dwarf_unwind_t *unwind, const elfheader_t *ehdr, #undef PARSE_INST box_free(init_statuses); box_free(init_table); - for (int i = 0; i < maxstacksize; ++i) { + for (uint64_t i = 0; i < maxstacksize; ++i) { box_free(table_stack[i]); } box_free(table_stack); diff --git a/src/elfs/elfloader.c b/src/elfs/elfloader.c index 39c83abc7f..587259684b 100644 --- a/src/elfs/elfloader.c +++ b/src/elfs/elfloader.c @@ -961,7 +961,7 @@ int RelocateElfPlt(lib_t *maplib, lib_t *local_maplib, int bindnow, elfheader_t* return -1; } if(need_resolver) { - if(pltResolver==~0LL) { + if(pltResolver==(uintptr_t)-1) { pltResolver = AddBridge(my_context->system, vFE, PltResolver, 0, "PltResolver"); } if(head->pltgot) { @@ -1216,7 +1216,7 @@ int LoadNeededLibs(elfheader_t* h, lib_t *maplib, int local, int bindnow, box64c DumpDynamicNeeded(h); int cnt = 0; // count the number of needed libs, and also grab soname - for (int i=0; inumDynamic; ++i) { + for (size_t i=0; inumDynamic; ++i) { if(h->Dynamic[i].d_tag==DT_NEEDED) ++cnt; if(h->Dynamic[i].d_tag==DT_SONAME) @@ -1226,7 +1226,7 @@ int LoadNeededLibs(elfheader_t* h, lib_t *maplib, int local, int bindnow, box64c if(h == my_context->elfs[0]) my_context->neededlibs = h->needed; int j=0; - for (int i=0; inumDynamic; ++i) + for (size_t i=0; inumDynamic; ++i) if(h->Dynamic[i].d_tag==DT_NEEDED) h->needed->names[j++] = h->DynStrTab+h->delta+h->Dynamic[i].d_un.d_val; diff --git a/src/emu/x64compstrings.c b/src/emu/x64compstrings.c index d61a516cc7..41216a2600 100644 --- a/src/emu/x64compstrings.c +++ b/src/emu/x64compstrings.c @@ -35,15 +35,15 @@ static int overrideIfDataInvalid(sse_regs_t* mem, int lmem, sse_regs_t* reg, int return (i&1)?((reg->uw[i]>=mem->uw[j])):((reg->uw[i]<=mem->uw[j])); case 0b10: // sb return (i&1)?((reg->sb[i]>=mem->sb[j])):((reg->sb[i]<=mem->sb[j])); - case 0b11: // sw + default: // sw return (i&1)?((reg->sw[i]>=mem->sw[j])):((reg->sw[i]<=mem->sw[j])); } break; default: // the others switch (imm8&1) { - case 0: // byte + case 0: // byte return (reg->ub[i] == mem->ub[j]); - case 1: // word + default: // word return (reg->uw[i] == mem->uw[j]); } } @@ -117,4 +117,4 @@ uint32_t sse42_compare_string_implicit_len(x64emu_t* emu, sse_regs_t* mem, sse_r while(lreg<16 && reg->ub[lreg]) ++lreg; } return sse42_compare_string_explicit_len(emu, mem, lmem, reg, lreg, imm8); -} \ No newline at end of file +} diff --git a/src/emu/x64run.c b/src/emu/x64run.c index 995144bb28..7bec6b91cc 100644 --- a/src/emu/x64run.c +++ b/src/emu/x64run.c @@ -174,7 +174,9 @@ int Run(x64emu_t *emu, int step) unimp = 1; goto fini; } - if(step==2) STEP2; + if(step==2) { + STEP2; + } #endif break; case 2: @@ -197,7 +199,9 @@ int Run(x64emu_t *emu, int step) unimp = 1; goto fini; } - if(step==2) STEP2; + if(step==2) { + STEP2; + } #endif break; } @@ -397,6 +401,7 @@ int Run(x64emu_t *emu, int step) break; case 0x62: /* BOUND Gd, Ed */ if(rex.is32bits) { + nextop = F8; FAKEED(0); } else { unimp = 1; diff --git a/src/emu/x64run66.c b/src/emu/x64run66.c index 03229b5e6e..cdbf3a469a 100644 --- a/src/emu/x64run66.c +++ b/src/emu/x64run66.c @@ -147,6 +147,7 @@ uintptr_t Run66(x64emu_t *emu, rex_t rex, int rep, uintptr_t addr) return Run66F30F(emu, rex, addr); #endif } + return 0; // unreachable case 0x1E: /* PUSH DS */ if(!rex.is32bits) { @@ -900,4 +901,4 @@ uintptr_t Run66(x64emu_t *emu, rex_t rex, int rep, uintptr_t addr) return 0; } return addr; -} \ No newline at end of file +} diff --git a/src/emu/x64run6764_32.c b/src/emu/x64run6764_32.c index 92ed0b8e62..4b4b667cb5 100644 --- a/src/emu/x64run6764_32.c +++ b/src/emu/x64run6764_32.c @@ -28,6 +28,7 @@ uintptr_t Test6764_32(x64test_t *test, rex_t rex, int rep, int seg, uintptr_t ad uintptr_t Run6764_32(x64emu_t *emu, rex_t rex, int rep, int seg, uintptr_t addr) #endif { + (void)rep; uint8_t opcode; uint8_t nextop; int8_t tmp8s; @@ -88,4 +89,4 @@ uintptr_t Run6764_32(x64emu_t *emu, rex_t rex, int rep, int seg, uintptr_t addr) return 0; } return addr; -} \ No newline at end of file +} diff --git a/src/emu/x64syscall.c b/src/emu/x64syscall.c index e80e7dae07..6201e4f420 100644 --- a/src/emu/x64syscall.c +++ b/src/emu/x64syscall.c @@ -61,8 +61,8 @@ void* my_mremap(x64emu_t* emu, void* old_addr, size_t old_size, size_t new_size, int32_t my_epoll_ctl(x64emu_t* emu, int32_t epfd, int32_t op, int32_t fd, void* event); int32_t my_epoll_wait(x64emu_t* emu, int32_t epfd, void* events, int32_t maxevents, int32_t timeout); int32_t my_epoll_pwait(x64emu_t* emu, int32_t epfd, void* events, int32_t maxevents, int32_t timeout, const sigset_t *sigmask); -pid_t my_vfork(x64emu_t* emu); #endif +pid_t my_vfork(x64emu_t* emu); int32_t my_fcntl(x64emu_t* emu, int32_t a, int32_t b, void* c); int32_t my_execve(x64emu_t* emu, const char* path, char* const argv[], char* const envp[]); @@ -401,7 +401,7 @@ void EXPORT x64Syscall(x64emu_t *emu) printf_log(LOG_NONE, "%s", buff); } // check wrapper first - int cnt = sizeof(syscallwrap) / sizeof(scwrap_t); + uint32_t cnt = sizeof(syscallwrap) / sizeof(scwrap_t); if(ssi_code && old_pc==pc && old_addr==addr && old_tid==tid && old_prot==prot) { printf_log(log_minimum, "%04d|Double %s (code=%d, pc=%p, addr=%p, prot=%02x)!\n", tid, signame, old_code, old_pc, old_addr, prot); -exit(-1); + exit(-1); } else { if((sig==SIGSEGV) && (info->si_code == SEGV_ACCERR) && ((prot&~PROT_CUSTOM)==5 || (prot&~PROT_CUSTOM)==7)) { static uintptr_t old_addr = 0; diff --git a/src/libtools/threads.c b/src/libtools/threads.c index e4f91d1579..dad14fe1f9 100644 --- a/src/libtools/threads.c +++ b/src/libtools/threads.c @@ -323,7 +323,7 @@ EXPORT int my_pthread_attr_setstacksize(x64emu_t* emu, void* attr, size_t stacks { (void)emu; //aarch64 have an PTHREAD_STACK_MIN of 131072 instead of 16384 on x86_64! - if(stacksize(1<(1u<g_cclosure_new(findGCallbackFct(callback), data, findGClosureNotify_Fct(destroy)); + return my->g_cclosure_new(findGCallbackFct(callback), data, findGClosureNotify_Fct(destroy)); } EXPORT void* my_g_cclosure_new_swap(x64emu_t* emu, void* callback, void* data, void* destroy) { - my->g_cclosure_new_swap(findGCallbackFct(callback), data, findGClosureNotify_Fct(destroy)); + return my->g_cclosure_new_swap(findGCallbackFct(callback), data, findGClosureNotify_Fct(destroy)); } EXPORT void my_g_closure_add_finalize_notifier(x64emu_t* emu, void* closure, void* data, void* f) @@ -939,4 +939,3 @@ EXPORT void* my_g_type_value_table_peek(x64emu_t* emu, size_t type) freeMy(); #include "wrappedlib_init.h" - diff --git a/src/wrapped/wrappedgstreamer.c b/src/wrapped/wrappedgstreamer.c index 9583143c62..847ea46dde 100644 --- a/src/wrapped/wrappedgstreamer.c +++ b/src/wrapped/wrappedgstreamer.c @@ -908,7 +908,7 @@ EXPORT void* my_gst_structure_new_valist(x64emu_t* emu, void* name, void* first, #else CREATE_VALIST_FROM_VALIST(V, emu->scratch); #endif - my->gst_structure_new_valist(name, first, VARARGS); + return my->gst_structure_new_valist(name, first, VARARGS); } EXPORT void* my_gst_make_element_message_details(x64emu_t* emu, void* name, uintptr_t* b) @@ -916,7 +916,7 @@ EXPORT void* my_gst_make_element_message_details(x64emu_t* emu, void* name, uint if(!name) return NULL; CREATE_VALIST_FROM_VAARG(b, emu->scratch, 1); - my->gst_structure_new_valist("detail", name, VARARGS); + return my->gst_structure_new_valist("detail", name, VARARGS); } EXPORT int my_gst_pad_start_task(x64emu_t* emu, void* pad, void* f, void* data, void* d) diff --git a/src/wrapped/wrappedgtk3.c b/src/wrapped/wrappedgtk3.c index 0a49279efa..cdc44219ad 100644 --- a/src/wrapped/wrappedgtk3.c +++ b/src/wrapped/wrappedgtk3.c @@ -720,7 +720,7 @@ EXPORT void my3_gtk_tree_view_column_set_cell_data_func(x64emu_t* emu, void* tre EXPORT void* my3_gtk_tree_store_new(x64emu_t* emu, uint32_t n, uintptr_t* b) { uintptr_t c[n]; - for(int i=0; igtk_tree_store_newv(n, c); } diff --git a/src/wrapped/wrappedlibc.c b/src/wrapped/wrappedlibc.c index 8be303b604..347a38e685 100644 --- a/src/wrapped/wrappedlibc.c +++ b/src/wrapped/wrappedlibc.c @@ -3065,7 +3065,7 @@ EXPORT int my_semctl(int semid, int semnum, int cmd, union semun b) return ret; } -EXPORT uint64_t userdata_sign = 0x1234598765ABCEF0; +EXPORT int64_t userdata_sign = 0x1234598765ABCEF0; EXPORT uint32_t userdata[1024]; EXPORT long my_ptrace(x64emu_t* emu, int request, pid_t pid, void* addr, uint32_t* data) diff --git a/src/wrapped/wrappedlibcups.c b/src/wrapped/wrappedlibcups.c index dc84686897..72b2a5319d 100644 --- a/src/wrapped/wrappedlibcups.c +++ b/src/wrapped/wrappedlibcups.c @@ -68,7 +68,7 @@ static void* find_cups_dest_cb_t_Fct(void* fct) EXPORT int my_cupsEnumDests(x64emu_t* emu, uint32_t flags, int msec, int* cancel, uint32_t type, uint32_t mask, void* f, void* data) { - my->cupsEnumDests(flags, msec, cancel, type, mask, find_cups_dest_cb_t_Fct(f), data); + return my->cupsEnumDests(flags, msec, cancel, type, mask, find_cups_dest_cb_t_Fct(f), data); } #define CUSTOM_INIT \ @@ -78,4 +78,3 @@ EXPORT int my_cupsEnumDests(x64emu_t* emu, uint32_t flags, int msec, int* cancel freeMy(); #include "wrappedlib_init.h" - diff --git a/src/wrapped/wrappedlibdl.c b/src/wrapped/wrappedlibdl.c index ac803569d4..7ccf0e1c05 100644 --- a/src/wrapped/wrappedlibdl.c +++ b/src/wrapped/wrappedlibdl.c @@ -65,7 +65,7 @@ int my_dlinfo(x64emu_t* emu, void* handle, int request, void* info) EXPORT; #define CLEARERR if(dl->last_error) {box_free(dl->last_error); dl->last_error = NULL;} -void RemoveDlopen(library_t** lib, int idx) +void RemoveDlopen(library_t** lib, size_t idx) { if(!my_context) return; diff --git a/src/wrapped/wrappedlibharfbuzz.c b/src/wrapped/wrappedlibharfbuzz.c index 8f4bb2c979..1d88201ffd 100644 --- a/src/wrapped/wrappedlibharfbuzz.c +++ b/src/wrapped/wrappedlibharfbuzz.c @@ -1190,13 +1190,13 @@ EXPORT int my_hb_font_funcs_set_user_data(x64emu_t* emu, void* funcs, void* key, return (int)my->hb_font_funcs_set_user_data(funcs, key, data, find_destroy_Fct(destroy), replace); } -EXPORT int my_hb_font_set_funcs(x64emu_t* emu, void* font, void* klass, void* data, void* destroy) +EXPORT void my_hb_font_set_funcs(x64emu_t* emu, void* font, void* klass, void* data, void* destroy) { (void)emu; my->hb_font_set_funcs(font, klass, data, find_destroy_Fct(destroy)); } -EXPORT int my_hb_font_set_funcs_data(x64emu_t* emu, void* font, void* data, void* destroy) +EXPORT void my_hb_font_set_funcs_data(x64emu_t* emu, void* font, void* data, void* destroy) { (void)emu; my->hb_font_set_funcs_data(font, data, find_destroy_Fct(destroy)); diff --git a/src/wrapped/wrappedpulse.c b/src/wrapped/wrappedpulse.c index 8e808d5527..c2ad381e96 100644 --- a/src/wrapped/wrappedpulse.c +++ b/src/wrapped/wrappedpulse.c @@ -783,7 +783,7 @@ static void* find_io_new_Fct(void* fct) // io_enable #define GO(A) \ static uintptr_t my_io_enable_fct_##A = 0; \ -static void* my_io_enable_##A(void* api, int events) \ +static void my_io_enable_##A(void* api, int events) \ { \ RunFunctionFmt(my_io_enable_fct_##A, "pi", api, events); \ } @@ -805,7 +805,7 @@ static void* find_io_enable_Fct(void* fct) // io_free #define GO(A) \ static uintptr_t my_io_free_fct_##A = 0; \ -static void* my_io_free_##A(void* e) \ +static void my_io_free_##A(void* e) \ { \ RunFunctionFmt(my_io_free_fct_##A, "p", e); \ } @@ -871,7 +871,7 @@ static void* find_time_new_Fct(void* fct) // time_restart #define GO(A) \ static uintptr_t my_time_restart_fct_##A = 0; \ -static void* my_time_restart_##A(void* e, void* t) \ +static void my_time_restart_##A(void* e, void* t) \ { \ RunFunctionFmt(my_time_restart_fct_##A, "pp", e, t); \ } @@ -893,7 +893,7 @@ static void* find_time_restart_Fct(void* fct) // time_free #define GO(A) \ static uintptr_t my_time_free_fct_##A = 0; \ -static void* my_time_free_##A(void* e) \ +static void my_time_free_##A(void* e) \ { \ RunFunctionFmt(my_time_free_fct_##A, "p", e); \ } @@ -913,10 +913,10 @@ static void* find_time_free_Fct(void* fct) return NULL; } // time_set_destroy -#define GO(A) \ -static uintptr_t my_time_set_destroy_fct_##A = 0; \ -static void my_time_set_destroy_##A(void* e, void* cb) \ -{ \ +#define GO(A) \ +static uintptr_t my_time_set_destroy_fct_##A = 0; \ +static void my_time_set_destroy_##A(void* e, void* cb) \ +{ \ RunFunctionFmt(my_time_set_destroy_fct_##A, "pp", e, AddCheckBridge(my_lib->w.bridge, vFppp, cb, 0, "my_time_set_destroy_cb")); \ } SUPER() @@ -959,7 +959,7 @@ static void* find_defer_new_Fct(void* fct) // defer_enable #define GO(A) \ static uintptr_t my_defer_enable_fct_##A = 0; \ -static void* my_defer_enable_##A(void* e, int b) \ +static void my_defer_enable_##A(void* e, int b) \ { \ RunFunctionFmt(my_defer_enable_fct_##A, "pi", e, b); \ } @@ -981,7 +981,7 @@ static void* find_defer_enable_Fct(void* fct) // defer_free #define GO(A) \ static uintptr_t my_defer_free_fct_##A = 0; \ -static void* my_defer_free_##A(void* e) \ +static void my_defer_free_##A(void* e) \ { \ RunFunctionFmt(my_defer_free_fct_##A, "p", e); \ } @@ -1025,7 +1025,7 @@ static void* find_defer_set_destroy_Fct(void* fct) // quit #define GO(A) \ static uintptr_t my_quit_fct_##A = 0; \ -static void* my_quit_##A(void* e, int retval) \ +static void my_quit_##A(void* e, int retval) \ { \ RunFunctionFmt(my_quit_fct_##A, "pi", e, retval); \ } diff --git a/src/wrapped/wrappedsdl2.c b/src/wrapped/wrappedsdl2.c index cf7451190e..930264c60f 100644 --- a/src/wrapped/wrappedsdl2.c +++ b/src/wrapped/wrappedsdl2.c @@ -566,7 +566,7 @@ static int get_sdl_priv(x64emu_t* emu, const char *sym_str, void **w, void **f) int EXPORT my2_SDL_DYNAPI_entry(x64emu_t* emu, uint32_t version, uintptr_t *table, uint32_t tablesize) { - int i = 0; + uint32_t i = 0; uintptr_t tab[tablesize]; int r = my->SDL_DYNAPI_entry(version, tab, tablesize); (void)r;