Merge pull request #157 from ptkis/adminsdk-key

Remove hardcoded Firebase credentials from the repo
ptkis · Dec 6, 2023 · ef35165 · ef35165
2 parents 2fe2b31 + 8bbd178
commit ef35165
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -39,6 +39,11 @@ jobs:
       - run: echo "$APPLICATION_SECRET_PROPERTIES" > src/test/resources/application-secret.properties
         env:
           APPLICATION_SECRET_PROPERTIES: ${{ secrets.APPLICATION_SECRET_PROPERTIES }}
+      - name: Get FIREBASE_JSON from secrets
+        run: |
+          echo $FIREBASE_JSON > src/main/resources/banyuwangi-dashboard-firebase-adminsdk.json
+        env:
+          FIREBASE_JSON: ${{ secrets.FIREBASE_JSON }}
       - name: Test and assemble with Gradle
         run: ./gradlew assemble
         env:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -35,6 +35,11 @@ jobs:
     - run: echo "$APPLICATION_SECRET_PROPERTIES" > src/test/resources/application-secret.properties
       env:
         APPLICATION_SECRET_PROPERTIES: ${{ secrets.APPLICATION_SECRET_PROPERTIES }}
+    - name: Get FIREBASE_JSON from secrets
+      run: |
+        echo $FIREBASE_JSON > src/main/resources/banyuwangi-dashboard-firebase-adminsdk.json
+      env:
+        FIREBASE_JSON: ${{ secrets.FIREBASE_JSON }}
     - name: Install docker
       run: |
         command docker -v || curl -fsSL get.docker.com | sudo bash

diff --git a/.gitignore b/.gitignore
@@ -42,3 +42,5 @@ out/
 *.mv.db
 *.trace.db
 *.lock.db
+
+src/main/resources/banyuwangi-dashboard-firebase-adminsdk.json
diff --git a/src/main/resources/banyuwangi-dashboard-firebase-adminsdk.json b/src/main/resources/banyuwangi-dashboard-firebase-adminsdk.json