-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: ics721 handling custom collections #84
Comments
Tried transferring this: https://interchain.arkprotocol.io/collections/juno1kpsy0mh58fzrl973ndvppujs9ea5xe9wggjhhg07c42l0yqk5n7st5800h/Atlas%20%23896 Now getting this error:
It is a custom AllNftInfo, CLI returns this: {
"data": {
"access": {
"owner": "juno1ke55z7catvdvnhvyyh0pkvs30t09me72vcxkh5",
"approvals": []
},
"info": {
"token_uri": "ipfs://QmPjCme3eFgNia4BuRV4Y19A8eQesBSPrVqYDc5cXWxnJa/896.json",
"extension": {
"token1": null,
"token2": null,
"vesting_period": 0,
"tier_index": 1,
"image": "ipfs://QmUAgzXDd4ZeE93etnSQAPnxZqDV1sYV2TTnFyU5iUCwUx/896.webp",
"image_data": null,
"external_url": null,
"description": "Atlas NFT is Cosmos' first generative music NFT, backed by 30 Juno. Atlas NFT is the governance of Atlas DAO, which aims to create sustainable value and passive yield for its members. The mission of Atlas DAO is to foster a thriving ecosystem that benefits all stakeholders, while also making a positive impact through charitable donations and volunteer work",
"name": "Atlas #896",
"attributes": [
{
"display_type": null,
"trait_type": "BACKGROUND",
"value": "LIQUIDBLUE"
},
{
"display_type": null,
"trait_type": "SHAPE",
"value": "CIRCLE"
},
{
"display_type": null,
"trait_type": "LEVEL",
"value": "LEVEL_1"
},
{
"display_type": null,
"trait_type": "HOLD",
"value": "EARTH"
},
{
"display_type": null,
"trait_type": "BACKLIGHT",
"value": "RED"
},
{
"display_type": null,
"trait_type": "CHARACTER",
"value": "ARIA"
},
{
"display_type": null,
"trait_type": "CLOTHES",
"value": "BLACK SS"
},
{
"display_type": null,
"trait_type": "ACCESSORIES",
"value": "NONE"
},
{
"display_type": null,
"trait_type": "OVERLAYS",
"value": "NONE"
},
{
"display_type": null,
"trait_type": "HEAD",
"value": "PONYTAIL"
},
{
"display_type": null,
"trait_type": "EYE",
"value": "BROWN"
},
{
"display_type": null,
"trait_type": "BASE",
"value": "Only Strings attached"
},
{
"display_type": null,
"trait_type": "HARMONY",
"value": "Small women Choir"
},
{
"display_type": null,
"trait_type": "MELODY",
"value": "A single Bouzouki"
},
{
"display_type": null,
"trait_type": "PATTERN",
"value": "Mallet groove"
},
{
"display_type": null,
"trait_type": "RHYTHM",
"value": "Trunk on trunk"
}
],
"background_color": null,
"animation_url": "ipfs://QmU8eh3xFoM3ePFWBVtXBKiikxKCqEHeh5TgdN5w2sq6hv/896.mp3",
"youtube_url": null
}
}
}
} |
With changes in #105 can transfer, but getting error on SG side: Also relayer errors: NOTE: since transfer fails, ofc it gets returned backed to owner on Juno |
fixed with PR #105 |
I was trying transferring a Juno NFT to Stargaze and got this error:
submessages: Error parsing into type cw721::query::ContractInfoResponse: unknown field
minter, expected
nameor
symbol: execute wasm contract failed [CosmWasm/wasmd@v0.45.0/x/wasm/keeper/keeper.go:395]
Reason is ics721 uses standard
cw721
, expectingContractInfoResponse
which should only containname
andsymbol
. But Juno collection has more than that.command:
junod query wasm contract-state smart juno1kpsy0mh58fzrl973ndvppujs9ea5xe9wggjhhg07c42l0yqk5n7st5800h '{"contract_info": {}}'
output:
Solution: instead of using restrictive
cw_serde
, we can useserde
for being more lenient and ignore all unknown fields.The text was updated successfully, but these errors were encountered: