Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalizer/fft graph not shown on Android phones #93

Open
jywarren opened this issue Apr 16, 2019 · 15 comments
Open

Equalizer/fft graph not shown on Android phones #93

jywarren opened this issue Apr 16, 2019 · 15 comments

Comments

@jywarren
Copy link
Member

jywarren commented Apr 16, 2019

#88, #87 and #92 fixed the audio security limits issue and installed an equalizer to display what sounds it can hear on the spectrum, for debugging. It's awesome!

image

However, on my Android phone in Chrome 73, I can't see the graph:

Screenshot_20190416-144130

I can't reproduce this on desktop Chrome:

image

Not sure what's happening here!

@jywarren
Copy link
Member Author

Here's the section that's supposed to draw the graph!

sketch.beginShape();
sketch.vertex(0, sketch.height * 0.9);
for (i = 0; i < spectrum.length / scale; i++) {
sketch.vertex(i * scale, sketch.map(spectrum[i], 0, 255, sketch.height * 0.8, 0));
}
sketch.vertex(sketch.width, sketch.height * 0.9);
sketch.endShape();

@jywarren jywarren pinned this issue May 5, 2019
@jywarren jywarren changed the title Equalizer/fft graph not shown on mobile phones Equalizer/fft graph not shown on Android phones May 5, 2019
@selevo
Copy link

selevo commented Jul 19, 2021

test soul brauser on android.
Chrome browser hasn't been very good lately

@jywarren
Copy link
Member Author

jywarren commented Aug 12, 2021 via email

@selevo
Copy link

selevo commented Aug 14, 2021

aww darn, any way you could test with a javascript console? Thanks for reporting!

https://editor.p5js.org/jywarren/sketches/rkztwSt8M
(android brouser)

#ReferenceError: webkitAudioContext is not defined
    at Class.init (https://webjack.io/dist/webjack.js:663:44)

    at new Class (https://webjack.io/dist/webjack.js:63:19)

    at (anonymous function) (https://jywarren.github.io/p5-webjack/lib.js:15:20)

    at (anonymous function) (https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.8.0/addons/p5.sound.min.js:24:4838)(https://github.com/publiclab/webjack/issues/93#issuecomment-882318312)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J4H77FVW53BB4UYSULTYPJENANCNFSM4HGN2Z7A> .

webkitAudioContext - is out of date

https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Migrating_from_webkitAudioContext

@jywarren
Copy link
Member Author

jywarren commented Aug 14, 2021 via email

@jywarren
Copy link
Member Author

Wow, we're actually at v0.7.3 of p5js:

<script src="https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.7.3/p5.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.7.3/addons/p5.dom.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.7.3/addons/p5.sound.min.js"></script>

Would you be able to try bumping the version in the CDN links and trying again? If not I can try.

Noting also that the code referenced in your error log mentions this wrapper library I also wrote, but there's no reference to "webkit" in the code there so I think that's not the issue. But still, good to notice the included code:

https://github.com/jywarren/p5-webjack/blob/main/lib.js

@jywarren
Copy link
Member Author

thanks so much for helping out here!!!

@selevo
Copy link

selevo commented Aug 15, 2021

i dont know how get js errors on android brausers whithout conect to PC
In android brausers no console.
at the moment I only have an Android smartphone

I can only validate code in some JavaScript sandbox, editor.p5js.org or others

@selevo
Copy link

selevo commented Aug 22, 2021

thanks so much for helping out here!!!
webjack.io-1629558757386.log

1

@jywarren
Copy link
Member Author

jywarren commented Aug 22, 2021 via email

@jywarren
Copy link
Member Author

That's odd... I see this:

Screen Shot 2021-08-22 at 12 54 30 PM

Let me see what's up.

@jywarren
Copy link
Member Author

What version of Chrome are you using?

@jywarren
Copy link
Member Author

I don't know if this is the problem on Android but it makes me wonder, what is your Android version and Android Chrome version too?

chrome://settings/help can help you determine this.

Would you be able to try out the other change as well, the update to p5js v1.4.0, to see if that helps?

#202 I've tried the update here. Do you know how to start it up to test? You could use GitPod --

http://gitpod.io/#https://github.com/publiclab/webjack/pull/202

once it starts up, you'll see the example page in the preview window.

@selevo
Copy link

selevo commented Sep 6, 2021

The interface there is very slow and it is intended for a computer, the page does not move well on the phone and the navigation is bad I can not check the scripts

@selevo
Copy link

selevo commented Nov 19, 2021

#208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants