Fix parameter name in manageChannelMembers #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
kleewho,
wkal-pubnub and
jguz-pubnub
as code owners
wkal-pubnub
reviewed
Dec 5, 2024
| @@ -1886,7 +1886,7 @@ actual interface PubNub : StatusEmitter, EventEmitter { | |||
| fun manageChannelMembers( | |||
| channel: String, | |||
| usersToSet: Collection<MemberInput>, | |||
| usersToRemove: Collection<String>, | |||
| usersIdsToRemove: Collection<String>, | |||
There was a problem hiding this comment.
Suggested change
| usersIdsToRemove: Collection<String>, | |
| userIdsToRemove: Collection<String>, |
There was a problem hiding this comment.
Good catch. I will change it.
wkal-pubnub
approved these changes
Dec 5, 2024
|
@pubnub-release-bot release kotlin as v10.3.1 |
|
@pubnub-release-bot release kotlin as v10.3.0 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added membershipType to Memberships and ChannelMembers APIs.
Added also a way to specify optional data being added to the response for Membership and ChannelMembers APIs.