Merge pull request #4419 from pulibrary/coverage-in-ci-only

Only run coveralls in CI, to speed up local test runs

Author: christinach

Gemfile

@@ -114,7 +114,7 @@ group :development, :test do
   gem 'rubocop-rails', require: false
   gem 'rubocop-performance', require: false
   gem 'capybara'
-  gem 'coveralls_reborn'
+  gem 'coveralls_reborn', require: false
   gem "erb_lint", require: false
   gem "erblint-github"
   gem 'pry-byebug'

spec/spec_helper.rb

@@ -1,17 +1,23 @@
 # frozen_string_literal: true
-require 'coveralls'
+def in_ci?
+  !ENV['CI'].nil? && ENV['CI'] == 'true'
+end
+
+require 'coveralls' if in_ci?
 require 'factory_bot'
 require 'webmock/rspec'
 
 # allow connections to localhost and bibdata marc record service
 WebMock.disable_net_connect!(allow_localhost: true,
                              allow: 'chromedriver.storage.googleapis.com')
 
-Coveralls.wear!('rails') do
-  add_filter '/lib/orangelight/browse_lists.rb'
-  add_filter '/app/models/orangelight.rb'
-  add_filter '/lib/tasks'
-  add_filter 'app/controllers/search_history_controller.rb'
+if in_ci?
+  Coveralls.wear!('rails') do
+    add_filter '/lib/orangelight/browse_lists.rb'
+    add_filter '/app/models/orangelight.rb'
+    add_filter '/lib/tasks'
+    add_filter 'app/controllers/search_history_controller.rb'
+  end
 end
 
 FactoryBot.find_definitions
@@ -21,9 +27,5 @@
   config.example_status_persistence_file_path = "tmp/rspec_examples.txt"
 end
 
-def in_ci?
-  !ENV['CI'].nil? && ENV['CI'] == 'true'
-end
-
 ENV['GRAPHQL_API_URL'] = 'https://figgy.princeton.edu/graphql' unless ENV['GRAPHQL_API_URL']
 ENV['FIGGY_URL'] = 'https://figgy.princeton.edu' unless ENV['FIGGY_URL']