Merge pull request #4704 from pulibrary/rbsc2fire

Change Aeon site name "RBSC" to "FIRE"

Author: regineheberlein

app/models/concerns/requests/aeon.rb

@@ -44,7 +44,7 @@ def site
       elsif location['library']['code'] == 'mudd'
         'MUDD'
       else
-        "RBSC"
+        "FIRE"
       end
     end
 
@@ -58,7 +58,7 @@ def holding_location_to_site(location_code)
         elsif location_code == 'mudd' && aeon_location?
           'MUDD'
         else
-          'RBSC'
+          'FIRE'
         end
       end
 

app/models/requests/aeon_url.rb

@@ -98,7 +98,7 @@ def thesis?
       def site
         return 'MUDD' if at_mudd?
         return 'MARQ' if at_marquand?
-        'RBSC'
+        'FIRE'
       end
   end
 end

spec/models/requests/aeon_url_spec.rb

@@ -32,8 +32,8 @@
   it 'takes the SubLocation from the holdings_1display' do
     expect(subject).to include('SubLocation=Euro+20Q')
   end
-  it 'typically uses RBSC as the Site' do
-    expect(subject).to include('Site=RBSC')
+  it 'typically uses FIRE (Firestone) as the Site' do
+    expect(subject).to include('Site=FIRE')
   end
   it 'takes the openurl iteminfo5 from the item id' do
     expect(subject).to include('rft.iteminfo5=23740186060006421')

spec/models/requests/requestable_spec.rb

@@ -304,8 +304,8 @@
     end
 
     describe '#site' do
-      it 'returns a RBSC site param' do
-        expect(requestable.site).to eq('RBSC')
+      it 'returns a FIRE site param' do
+        expect(requestable.site).to eq('FIRE')
       end
     end
 
@@ -468,7 +468,7 @@
     describe '#aeon_basic_params' do
       it 'includes a Site param' do
         expect(requestable.aeon_basic_params.key?(:Site)).to be true
-        expect(requestable.aeon_basic_params[:Site]).to eq('RBSC')
+        expect(requestable.aeon_basic_params[:Site]).to eq('FIRE')
       end
 
       it 'has a Reference NUmber' do