Skip to content

Commit d3eb770

Browse files
authored
Merge pull request #1175 from pulibrary/sibling-ids-present
ensure sibling ids are present for linked doc query
2 parents accdc39 + 88fc8d8 commit d3eb770

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.rubocop.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Metrics/AbcSize:
3838
- 'app/models/concerns/blacklight/solr/document/marc.rb'
3939
- 'app/models/concerns/blacklight/document/dublin_core.rb'
4040
- 'app/models/concerns/blacklight/document/ris.rb'
41+
- 'app/services/linked_document_resolver.rb'
4142
- 'config/initializers/requests_initializer.rb'
4243
- 'lib/orangelight/bibdata.rb'
4344
- 'lib/orangelight/browse_lists.rb'

app/services/linked_document_resolver.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ def initialize(root:, siblings:, solr_field:)
1818
# Retrieves the Solr documents for each adjacent node
1919
# @return [Array<SolrDocument>] sibling documents
2020
def siblings
21-
return [] unless response.key?('response') && !response['response']['docs'].empty?
21+
return [] unless @siblings.present? && response.key?('response') &&
22+
!response['response']['docs'].empty?
2223

2324
sibling_docs = response['response']['docs'].reject { |document| document['id'] == @root }
2425
sibling_docs.map { |document| SolrDocument.new(document) }

0 commit comments

Comments
 (0)