-
Notifications
You must be signed in to change notification settings - Fork 92
Snitch isa extensions #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
igor-sachok
wants to merge
2
commits into
pulp-platform:develop
Choose a base branch
from
igor-sachok:snitch_isa_extensions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Snitch isa extensions #287
igor-sachok
wants to merge
2
commits into
pulp-platform:develop
from
igor-sachok:snitch_isa_extensions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colluca
requested changes
Nov 18, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I think it mostly looks good, but there are two major things to rework IMO:
- the shared vs. private muldiv configuration, and new vs. old IPU
- the organization of the SW tests
See detailed comments below.
d89177d to
28a7e0f
Compare
8d2893c to
016b381
Compare
707cd0c to
dc18493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameterized XPULPv2 extension to Snitch. Each XPULPv2 sub-extension can now be enabled or disabled individually through the configuration file. An example configuration demonstrating these options is provided under xpulpv2.
Also introduces a private multiplier flag for the CC.
To use the corresponding LLVM model when building software, set
SN_MCPU=snitch-mempoolin themake swcommand.Tests for Snitch with XPULPv2 have been added to the
sw/testsdirectory and verified through CI.TODO