You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is that the lowerbound uses pulpcore~=3.49, which means it shouldnt have any prn stuff in this public API at all. And that's what the bindings diff says here:
$ # build-api.json was generated in the build step based on rpm installation like "pip install rpm -c ci_constraints.txt"
$ # test-api.json was generated in workflows/scripts/script.sh, based on container env, which has also "-c lowebound_contraints.txt"
$ jsondiff --indent 2 build-api.json test-api.json ||true
{
"op": "remove",
"path": "/components/schemas/rpm.ModulemdObsoleteResponse/properties/prn"
},
{
"op": "remove",
"path": "/components/schemas/rpm.ModulemdResponse/properties/prn"
},
So we are using the built-client (the client that was built in the build.yml step), which was generated using a different pulpcore version than the one in our test environement installation. I've heard of this problem several times, but had never experienced such a concrete example. Yet another "that's why we are stop publishing bindings".
Considerations
This code gives some warnings about this problem, and its where the client package is being selected.
But we can't know what pulpcore was used in the built-client (or its schema) at this point to make some kind of comparision because it doesnt show anywhere in the schema or package metadata (which is unfortunate, and maybe we should add this information on the schema, at least).
Anyway, I'm not sure what approach to take here. I'm assuming we want those to match, so maybe we could always use the client generate there (in the scripts/script.sh)?
The text was updated successfully, but these errors were encountered:
The problem
Recently on rpm CI we got an error on the lowerbound tests related to the introduction of prns on pulpcore==3.63.0.
The problem is that the lowerbound uses pulpcore~=3.49, which means it shouldnt have any prn stuff in this public API at all. And that's what the bindings diff says here:
So we are using the built-client (the client that was built in the build.yml step), which was generated using a different pulpcore version than the one in our test environement installation. I've heard of this problem several times, but had never experienced such a concrete example. Yet another "that's why we are stop publishing bindings".
Considerations
This code gives some warnings about this problem, and its where the client package is being selected.
But we can't know what pulpcore was used in the built-client (or its schema) at this point to make some kind of comparision because it doesnt show anywhere in the schema or package metadata (which is unfortunate, and maybe we should add this information on the schema, at least).
Anyway, I'm not sure what approach to take here. I'm assuming we want those to match, so maybe we could always use the client generate there (in the
scripts/script.sh
)?The text was updated successfully, but these errors were encountered: