Skip to content

Commit 698c4eb

Browse files
authored
Merge pull request #618 from gerrod3/pv-fixes4
Fix settings not being passed to publish action
2 parents c4408a0 + 5852d38 commit 698c4eb

File tree

2 files changed

+29
-4
lines changed

2 files changed

+29
-4
lines changed

.github/actions/publish_images/action.yml

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,36 @@ inputs:
1111
tags:
1212
description: 'List of tags the images are to be published under'
1313
required: true
14+
github_token:
15+
description: 'Github secret token'
16+
required: true
17+
docker_bot_username:
18+
description: 'Docker username login'
19+
required: true
20+
docker_bot_password:
21+
description: 'Docker password login'
22+
required: true
23+
quay_bot_username:
24+
description: 'Quay username login'
25+
required: true
26+
quay_bot_password:
27+
description: 'Quay password login'
28+
required: true
1429

1530
runs:
1631
using: "composite"
1732
steps:
1833
- name: Github login
1934
env:
20-
PULP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
35+
PULP_GITHUB_TOKEN: ${{ inputs.github_token }}
2136
PULP_GITHUB_USERNAME: ${{ github.actor }}
2237
run: echo "$PULP_GITHUB_TOKEN" | podman login -u "$PULP_GITHUB_USERNAME" --password-stdin ghcr.io
2338
shell: bash
2439

2540
- name: Docker login
2641
env:
27-
DOCKER_BOT_PASSWORD: ${{ secrets.DOCKER_BOT_PASSWORD }}
28-
DOCKER_BOT_USERNAME: ${{ secrets.DOCKER_BOT_USERNAME }}
42+
DOCKER_BOT_PASSWORD: ${{ inputs.docker_bot_password }}
43+
DOCKER_BOT_USERNAME: ${{ inputs.docker_bot_username }}
2944
run: echo "$DOCKER_BOT_PASSWORD" | podman login -u "$DOCKER_BOT_USERNAME" --password-stdin docker.io
3045
shell: bash
3146

.github/workflows/release.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
if [ "${{ github.ref_name }}" == "latest" ]; then
125125
tags="${tags} ${NIGHTLY_VERSION}-${python_version} ${NIGHTLY_BRANCH}-${python_version}"
126126
fi
127-
if [ "${{ inputs.python_version }}" == "3.9" ]; then
127+
if [ "${{ env.PYTHON_VERSION }}" == "3.9" ]; then
128128
tags="${tags} ${PULPCORE_VERSION} ${PULPCORE_BRANCH}"
129129
if [ "${{ github.ref_name }}" == "latest" ]; then
130130
tags="${tags} ${NIGHTLY_VERSION} ${NIGHTLY_BRANCH} latest"
@@ -139,6 +139,11 @@ jobs:
139139
image_names: "base pulp-ci-centos9"
140140
tags: ${{ env.TAGS }}
141141
build_tag: ${{ github.ref_name }}
142+
github_token: ${{ secrets.GITHUB_TOKEN }}
143+
docker_bot_username: ${{ secrets.DOCKER_BOT_USERNAME }}
144+
docker_bot_password: ${{ secrets.DOCKER_BOT_PASSWORD }}
145+
quay_bot_username: ${{ secrets.QUAY_BOT_USERNAME }}
146+
quay_bot_password: ${{ secrets.QUAY_BOT_PASSWORD }}
142147

143148
app-images:
144149
needs: base-images
@@ -207,6 +212,11 @@ jobs:
207212
image_names: ${{ env.IMAGES }}
208213
tags: ${{ env.TAGS }}
209214
build_tag: ${{ matrix.image_variant == 'nightly' && 'nightly' || github.ref_name }}
215+
github_token: ${{ secrets.GITHUB_TOKEN }}
216+
docker_bot_username: ${{ secrets.DOCKER_BOT_USERNAME }}
217+
docker_bot_password: ${{ secrets.DOCKER_BOT_PASSWORD }}
218+
quay_bot_username: ${{ secrets.QUAY_BOT_USERNAME }}
219+
quay_bot_password: ${{ secrets.QUAY_BOT_PASSWORD }}
210220

211221
- name: Logs
212222
if: always()

0 commit comments

Comments
 (0)