-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support null CONTENT_ORIGIN #3856
Comments
The place where we're affected is when we try to auto-generate the config.repo file - baseurl wants to be a full URL, not relative. We can do one of a few things here :
See https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/models/repository.py#L526 for the code that's affected |
re: 3, It would likely be an API breaking change to the I think I'm partial to option 2 personally |
IMHO the feature is described as if content origin is not set, the base url is the same as from the incoming request. So ideally pulpcore would come with a helper function to extract that from the request so we can do a simple search and replace for edit: AFTER some discussion (e.g. that the request may not know the original URL in all deployments) I agree with 2: Explicitly telling the user it's impossible and maybe bring more scenarios back later when we know it's possible. Existing installations will have the setting anyway, so nothing changes for them. |
Removed tests/upgrade directory - these tests don't test anything current, and have not actually been run in years. fixes pulp#3856.
Removed tests/upgrade directory - these tests don't test anything current, and have not actually been run in years. fixes pulp#3856.
Removed tests/upgrade directory - these tests don't test anything current, and have not actually been run in years. fixes pulp#3856.
Removed tests/upgrade directory - these tests don't test anything current, and have not actually been run in years. fixes pulp#3856.
As per pulp/pulpcore#5931, Pulp plugins need to support the possibility of the value provided for CONTENT_ORIGIN being
None
The text was updated successfully, but these errors were encountered: