-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another field to the RepositoryVersion
model to store additional information.
#2998
Labels
Comments
Possible names for the new field:
It is really an arbitrary JSON field, that could be used by plugin authors for almost anything, hence my first two suggestions are very generic. The use case we have in mind for |
hstct
added a commit
to ATIX-AG/pulpcore
that referenced
this issue
Aug 2, 2022
hstct
added a commit
to ATIX-AG/pulpcore
that referenced
this issue
Aug 3, 2022
ipanova
pushed a commit
that referenced
this issue
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We are looking to implement an optimize sync feature in
pulp_deb
. In order to do that we want to store data in adict
format which contains information about the remote options used in the latest sync as well assha256
values for the repository files. These will be used to compare when trying to sync a repository again to see if something has changed and skip certain steps if it hasn't.Describe the solution you'd like
Adding another field to
RepositoryVersion
model that can store a.JSONField(default=dict)
. This way a repository can always look up the lastest version to get the previous data.Describe alternatives you've considered
pulp_rpm
uses theirRepository
model to save this data which works too. However there were concerns of the mutability of the data when stored this way.Another solution would be adding a subclass of
RepositoryVersion
topulp_deb
. Since there is not any subclass of this model present in any plugin so far, this seems a bit overkill to just add one additional field.Additional context
For context the PR for this feature in
pulp_deb
: pulp/pulp_deb#570The text was updated successfully, but these errors were encountered: