Immediate async tasks are not awaited

[mdellweg]

Tasks defined as async coroutines are not properly handled when run immediate by the api worker.

[gerrod3]

How so, am I missing something it looks like they are:

pulpcore/pulpcore/tasking/tasks.py

Lines 69 to 72 in 21f2c21

	if asyncio.iscoroutine(result):
	_logger.debug(_("Task is coroutine %s"), task.pk)
	loop = asyncio.get_event_loop()
	loop.run_until_complete(result)

[pedro-psb]

Hmm, if you see the line above, the actual task code (func) is called as a sync function.
This is checking the task return value is a coroutine. I didn't know we even did something with the task fn return value.
Or that's how async tasks are supposed to be? Like wrapped in a sync function.

Also, do you know any task defined as an async coroutine? I feel like Mathias once said that there were none, really.

pulpcore/pulpcore/tasking/tasks.py

Lines 68 to 72 in 21f2c21

	result = func(*args, **kwargs)
	if asyncio.iscoroutine(result):
	_logger.debug(_("Task is coroutine %s"), task.pk)
	loop = asyncio.get_event_loop()
	loop.run_until_complete(result)

[gerrod3]

>>> import asyncio
>>> async def hello():
...     print("hello")
...     
>>> a = hello()
>>> asyncio.iscoroutine(a)
True
>>> loop = asyncio.get_event_loop()
<python-input-4>:1: DeprecationWarning: There is no current event loop
  loop = asyncio.get_event_loop()
>>> loop = asyncio.new_event_loop()
>>> loop.run_until_complete(a)
hello

With my current understanding of asyncio I think we have valid handling code, the async code won't run till put into an event loop. Our only potential problem is that I don't know what the status of the current event loop is in the api worker, so we might be calling deprecated code (deprecated in python 3.12 to call get_event_loop without a running loop).

[pedro-psb]

Oh, I see, thanks for clarifying! Asyncio is not in my heart yet 😅

[mdellweg]

First, yes, we don't have any async tasks yet. But also I cannot see what tipped me off back then. Maybe it got fixed in the meantime... I'm OK with closing this one.