-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I can specify how long workers should wait during graceful shutdown #6242
Comments
Well heartbeat duration is afaik a setting. If we want more precise timing of stuff we need to rewrite the workers using async python. |
I'm supportive to position the setting as a number of heartbeats and not "a specific number of seconds" if that makes it easier. |
I think specifying seconds is fine. We just need to document that it's not a precise measure. |
I just saw, that on sending SIGTERM or SIGHUP the current task should be awaited forever. |
The new setting is measured in seconds. Also added some clarification around graceful shutdown. fixes pulp#6242
The new setting is measured in seconds. Also added some clarification around graceful shutdown. fixes pulp#6242
The new setting is measured in seconds. Also added some clarification around graceful shutdown. fixes pulp#6242
See this comment which discusses exposing the
TASK_GRACE_INTERVAL
as a setting. This is an RFE requesting that.I don't know how long a heartbeat is so if the setting is expressed in heartbeats (which I think I'm ok with), then I need to know how long that is.
As a user, it would be nicer to me if it was expressable in seconds. For example we also have k8s hard timeout values and those are expressed in seconds, and we need to set these similarly and together, so having them all on a seconds timescale is nicer for me. It'll be ok though if not.
The text was updated successfully, but these errors were encountered: