Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Dismiss this Version" button is not working in pulsar-updater #784

Closed
5 tasks done
kiskoza opened this issue Oct 22, 2023 · 0 comments · Fixed by #785
Closed
5 tasks done

The "Dismiss this Version" button is not working in pulsar-updater #784

kiskoza opened this issue Oct 22, 2023 · 0 comments · Fixed by #785
Labels
bug Something isn't working

Comments

@kiskoza
Copy link
Contributor

kiskoza commented Oct 22, 2023

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

I originally discovered this issue on 1.108.0, but I was able to reproduce it with the latest codebase. It started with #733 , I wasn't able to run Pulsar on Ubuntu 20.04, but then the issue was found and the official answer is that I should wait for the next release and stay on 1.108.0 for now.

However, anytime I opened the editor (mostly in the morning, this will be relevant later), I got the notification that there's a new version (1.110.0) available. I always clicked on the "Dismiss this Version" button, but then I got it again the next day.

Pulsar version

1.108.0

Which OS does this happen on?

🐧 Debian based (Linux Mint, Ubuntu, etc.)

OS details

Ubuntu 20.04

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  1. Install a non-latest version of Pulsar (e.g.: 1.108.0)
  2. Open Pulsar
  3. When the pulsar-updater notification appears, click on "Dismiss this version" (e.g.: 1.110.0)
  4. Close Pulsar and wait 5 hours (*)
  5. Open Pulsar again
  6. Expected behaviour: the pulsar-updater won't show the notification about 1.110.0
  7. What happened? pulsar-updater is there again

Notes: I found it in the code that 5 hours is the current expire time, but you don't need to wait 5 hours, you can edit the localstorage for pulsar-updater:last-update-check 's createdOn value to trigger the bug earlier.

Additional Information:

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant