Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace ESLint and Prettier to Biome #574

Merged
merged 13 commits into from
Jul 20, 2024

Conversation

m1sk9
Copy link
Member

@m1sk9 m1sk9 commented Jul 20, 2024

#568

What does this PR do?

Pulsate で使用している ESLint, Prettier を Biome に置き換えます.

  • Prettier の設定のみ Migrate しました. ESLint の設定は Migrate 出来なかったため Biome の推奨ルール ( recommend ) を使用しています.
  • Biome の Import Sort については詳しく確認してないのでレビューで確認してください.

Additional information

Linter で警告されたルールについては処置がディスカッション内で以下のように処置するようにしました.

  • noUnreachableSuper: 採用. この PR 内で修正します.
  • noShadowRestrictedNames: 無効.
  • noNonNullAssertion: 一時的なもののため, コメントで無効にします.

@m1sk9 m1sk9 added the T: development Development Environment Issues & PR label Jul 20, 2024
@m1sk9 m1sk9 self-assigned this Jul 20, 2024
@m1sk9 m1sk9 force-pushed the replace-eslint-and-prettier-to-biome branch from 59bd1d9 to fe4c76d Compare July 20, 2024 11:51
@m1sk9 m1sk9 force-pushed the replace-eslint-and-prettier-to-biome branch from acf2414 to 1d29f95 Compare July 20, 2024 12:02
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.62%. Comparing base (0851aec) to head (355e0b4).

Files Patch % Lines
pkg/accounts/adaptor/controller/account.ts 0.00% 1 Missing ⚠️
pkg/drive/adaptor/controller/drive.ts 0.00% 1 Missing ⚠️
pkg/notes/adaptor/controller/note.ts 0.00% 1 Missing ⚠️
pkg/timeline/adaptor/controller/timeline.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #574       +/-   ##
===========================================
- Coverage   66.21%   51.62%   -14.60%     
===========================================
  Files         111      110        -1     
  Lines        8330     8295       -35     
  Branches      759      729       -30     
===========================================
- Hits         5516     4282     -1234     
- Misses       2814     4013     +1199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1sk9 m1sk9 marked this pull request as ready for review July 20, 2024 12:42
@m1sk9 m1sk9 enabled auto-merge (squash) July 20, 2024 13:03
Copy link
Member

@laminne laminne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動きそう

@m1sk9 m1sk9 merged commit b7afce2 into main Jul 20, 2024
4 of 5 checks passed
@m1sk9 m1sk9 deleted the replace-eslint-and-prettier-to-biome branch July 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: development Development Environment Issues & PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants