Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor run-tests-command.yml #1661

Closed
cnunciato opened this issue Jul 4, 2024 · 1 comment · Fixed by #1663
Closed

Refactor run-tests-command.yml #1661

cnunciato opened this issue Jul 4, 2024 · 1 comment · Fixed by #1663
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone

Comments

@cnunciato
Copy link
Member

cnunciato commented Jul 4, 2024

This is a very large file that has a ton of duplication and is much harder to understand than it needs to be. We should clean it up and remove what we can to make it more maintainable.

@cnunciato
Copy link
Member Author

cnunciato commented Jul 4, 2024

There's a bunch of additional cleanup we could do on the workflows in this repo:

  • Fix and refactor the long-failing https://github.com/pulumi/examples/actions/workflows/cron.yml (probably as we did with pulumi/templates, where we now use one workflow and trigger it on multiple events)
  • Delete the smoke-test-* workflows, as no one seems to be using them
  • Fix up the workflow naming to align with pulumi/templates

@cnunciato cnunciato added this to the 0.107 milestone Jul 4, 2024
@cnunciato cnunciato self-assigned this Jul 4, 2024
@cnunciato cnunciato added the kind/engineering Work that is not visible to an external user label Jul 4, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants