Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass resource token into applyAzureSpecificDiff #3767

Open
danielrbradley opened this issue Dec 10, 2024 · 1 comment
Open

Pass resource token into applyAzureSpecificDiff #3767

danielrbradley opened this issue Dec 10, 2024 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@danielrbradley
Copy link
Member

The applyAzureSpecificDiff method does not currently have any awareness of what type of resource it's applying to. When introducing resource-specific customisations, we should accurately target specific resources, therefore we should ensure that the required information is passed to this method to make accurate decisions.

func applyAzureSpecificDiff(diff *resource.ObjectDiff) {

Additionally, the API version could be critical information when considering changes, as old API versions might use different values for fields which cause replacement, such as the existing SKU migration for Managed Clusters.

@danielrbradley danielrbradley added the kind/engineering Work that is not visible to an external user label Dec 10, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 10, 2024
@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Dec 10, 2024
@EronWright
Copy link
Contributor

The missing ingredient at the provider protocol level is the type token associated with the old state. Combined with #3766 we would have all the information needed to drive migration logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
Status: No status
Development

No branches or pull requests

3 participants