From ced09a5caaeaddf561c82ff8ea1f273f3f5280cb Mon Sep 17 00:00:00 2001 From: VenelinMartinov Date: Wed, 8 May 2024 16:20:52 +0100 Subject: [PATCH] Dont skip tests by default (#2011) Highly unexpected behaviour, I think it's much more natural to fail when the required env vars are not set. EDIT: Even that was unnecessary, azure sets that config by default: https://www.pulumi.com/registry/packages/azure-native/installation-configuration/#configuration-options --- examples/examples_test.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/examples/examples_test.go b/examples/examples_test.go index 05ae8b6de0..0e61d9be3c 100644 --- a/examples/examples_test.go +++ b/examples/examples_test.go @@ -21,14 +21,6 @@ func skipIfShort(t *testing.T) { } } -func getEnviron(t *testing.T) string { - env := os.Getenv("ARM_ENVIRONMENT") - if env == "" { - t.Skipf("Skipping test due to missing ARM_ENVIRONMENT environment variable") - } - - return env -} func getLocation(t *testing.T) string { azureLocation := os.Getenv("ARM_LOCATION") @@ -50,12 +42,10 @@ func getCwd(t *testing.T) string { } func getBaseOptions(t *testing.T) integration.ProgramTestOptions { - environ := getEnviron(t) azureLocation := getLocation(t) return integration.ProgramTestOptions{ Config: map[string]string{ - "azure:environment": environ, - "azure:location": azureLocation, + "azure:location": azureLocation, }, } }