Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java release failures are silently ignored #16

Open
t0yv0 opened this issue Sep 15, 2023 · 2 comments
Open

Java release failures are silently ignored #16

t0yv0 opened this issue Sep 15, 2023 · 2 comments
Labels
kind/engineering Work that is not visible to an external user language/java

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 15, 2023

What happened?

Because of the use of:

  continue-on-error: true

The following kind of error is ignored and the job succeeds:

public static RandomUuid get(String name, Output<String> id, @Nullable RandomUuidState state, @Nullable com.pulumi.resources.CustomResourceOptions options) {
                             ^
14 warnings

> Task :javadocJar
> Task :sourcesJar
> Task :signMainPublicationPublication
> Task :publishMainPublicationPublicationToSonatypeRepository
> Task :publishToSonatype
> Task :closeSonatypeStagingRepository
> Task :releaseSonatypeStagingRepository FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':releaseSonatypeStagingRepository'.
> Staging repository is not in desired state [released, not_found]: StagingRepository(id=compulumi-6023, state=closed, transitioning=false). It is unexpected. Please checkNexus logs using its web interface - it can be caused by validation rules violation. If not, please report it to https://github.com/gradle-nexus/publish-plugin/issues/ with '--info' logs

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

BUILD FAILED in 2m 13s
13 actionable tasks: 13 executed
Error: Gradle build failed: process exited with status 1

Therefore no monitoring is done java release failures.

Example

This just happened in pulumi-random.

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 15, 2023
@mikhailshilkov mikhailshilkov added kind/engineering Work that is not visible to an external user language/java and removed kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 19, 2023
@iwahbe
Copy link
Member

iwahbe commented Dec 28, 2023

Do we want to take removing continue-on-error: true from java? My understanding was that the current java publishing process was too flakey to be load bearing. Has anything changed here?

@t0yv0
Copy link
Member Author

t0yv0 commented May 30, 2024

pulumi/pulumi-java#830 is the underlying reason for continue-on-error: true that'd be great to mitigate, otherwise these failures make all ecosystem publishing fail as well (since it's not isolated to java).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user language/java
Projects
None yet
Development

No branches or pull requests

3 participants