Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI for feature flags #2432

Closed
VenelinMartinov opened this issue Sep 20, 2024 · 4 comments · Fixed by #2446
Closed

Set up CI for feature flags #2432

VenelinMartinov opened this issue Sep 20, 2024 · 4 comments · Fixed by #2446
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

We roll out bridge features under feature flags and these tend to take a while. We'd like to make sure that new development in the repo does not break these, so we should run CI for each feature flag.

Had some issues with this during #1785

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Sep 20, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 20, 2024
@VenelinMartinov
Copy link
Contributor Author

Specifically we'd like to run CI on https://github.com/pulumi/home/issues/3560

@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Sep 20, 2024
@iwahbe
Copy link
Member

iwahbe commented Sep 20, 2024

We would presumably need to run CI on all permutations of feature flags, since if we run CI with all flags on but our releases don't have all flags on, we would have untested code being released.

@VenelinMartinov
Copy link
Contributor Author

Yeah, all permutations is the plan, or at least the meaningful ones

This was referenced Sep 20, 2024
Closed
Merged
VenelinMartinov added a commit that referenced this issue Sep 26, 2024
@VenelinMartinov
Run bridge CI for feature flags (#2446)
cc6374c 
This allows us to continuously test feature flags before they are
released. This will help us not regress on behaviour there.

fixes #2432
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 26, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2446 and shipped in release v3.92.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run bridge CI for feature flags pulumi/pulumi-terraform-bridge
3 participants
@iwahbe @VenelinMartinov @pulumi-bot