Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SageMaker template causing test failures #646

Closed
scottslowe opened this issue Sep 12, 2023 · 2 comments
Closed

SageMaker template causing test failures #646

scottslowe opened this issue Sep 12, 2023 · 2 comments
Assignees
@usrbinkat
Labels
area/templates impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/no-repro This issue wasn't able to be reproduced

Comments

@scottslowe
Copy link
Contributor

The sagemaker-aws-python template is causing test failures because the tests expect no changes, and the Pulumi program reports changes related to the Cloudwatch metrics.
@scottslowe scottslowe added kind/engineering Work that is not visible to an external user impact/reliability Something that feels unreliable or flaky area/templates labels Sep 12, 2023
@scottslowe
Copy link
Contributor Author

#644 provides a short-term fix by unsetting the important: true property and therefore bypasses the tests.

@cnunciato cnunciato added the resolution/no-repro This issue wasn't able to be reproduced label Sep 14, 2023
@cnunciato
Copy link
Contributor

Following up from triage this morning, I think we can close this, yeah -- I've run this several times myself in various ways and always gotten no diff:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usrbinkat usrbinkat

Labels
area/templates impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/no-repro This issue wasn't able to be reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnunciato @scottslowe @usrbinkat