Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several templates still referencing AWS v5 #657

Closed
EvanBoyle opened this issue Oct 5, 2023 · 4 comments
Closed

Several templates still referencing AWS v5 #657

EvanBoyle opened this issue Oct 5, 2023 · 4 comments
Assignees
@scottslowe
Labels
area/templates kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.100

Comments

@EvanBoyle
Copy link
Contributor

Ran into this with the aws-typescript template which is very commonly used. Did not exhaustively check all templates, but this query shows four ts/js templates still referencing v5. We should do an audit on other languages as well.

https://github.com/search?q=repo%3Apulumi%2Ftemplates+%22%40pulumi%2Faws%22+%22%5E5%22&type=code
@EvanBoyle EvanBoyle added the kind/bug Some behavior is incorrect or out of spec label Oct 5, 2023
@scottslowe
Copy link
Contributor

scottslowe commented Oct 12, 2023 •
edited
Loading

Every single instance found in that search also pulls in pulumi/awsx, which prevents us (currently) from being able to move to AWS v6. When the AWSX v2 upgrade happens, then these templates can be updated.

@scottslowe
Copy link
Contributor

It looks like only the following templates are affected:

  • aws-fsharp
  • aws-visualbasic

@scottslowe
Copy link
Contributor

This is fixed by #752, will close this issue once that PR merges

@scottslowe scottslowe added this to the 0.100 milestone Feb 14, 2024
@scottslowe scottslowe self-assigned this Feb 14, 2024
@scottslowe
Copy link
Contributor

Fixed via #752 (and a number of other prior PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottslowe scottslowe

Labels
area/templates kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.100
Development

No branches or pull requests
2 participants
@scottslowe @EvanBoyle