Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS cluster templates should use get_int #677

Closed
aaronkao opened this issue Nov 1, 2023 · 1 comment · Fixed by #757
Closed

EKS cluster templates should use get_int #677

aaronkao opened this issue Nov 1, 2023 · 1 comment · Fixed by #757
Assignees
Labels
area/templates kind/enhancement Improvements or new features resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@aaronkao
Copy link
Contributor

aaronkao commented Nov 1, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

https://github.com/pulumi/templates/blob/ad915fc3e3558493cbc689e5fa529500c359999b/kubernetes-aws-python/__main__.py#L7C57-L7C57

This currently uses get_float and should be get_int instead because you can't provision a fraction of an instance.

Affected area/feature

The default's won't cause errors however if someone does manage to input a float number, AWS would throw this error ["Encountered non numeric value for property DesiredCapacity"]

@aaronkao aaronkao added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 1, 2023
@desteves
Copy link

desteves commented Nov 2, 2023

A few more values that should be represented as ints across the templates repo can be found here https://github.com/search?q=repo%3Apulumi%2Ftemplates%20float&type=code

@desteves desteves added the size/S Estimated effort to complete (1-2 days). label Nov 2, 2023
@cnunciato cnunciato removed the needs-triage Needs attention from the triage team label Nov 6, 2023
@scottslowe scottslowe self-assigned this Feb 16, 2024
@scottslowe scottslowe added this to the 0.101 milestone Feb 21, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/templates kind/enhancement Improvements or new features resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants