Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing directly from pundit package #64

Open
chrisalley opened this issue Sep 14, 2023 · 0 comments
Open

Allow importing directly from pundit package #64

chrisalley opened this issue Sep 14, 2023 · 0 comments
Assignees
Labels

Comments

@chrisalley
Copy link
Collaborator

Currently we're including too much code in the package itself, including both dist and src directories. The way the node_modules subfolder is structured means that we cannot import from the pundit package directly.

  • An index.js should be included in the root of the package
  • We shouldn't include uncompiled TypeScript code in the package
  • import { Policy, When, PunditProvider } from 'pundit/dist/pundit.mjs' should become import { Policy, When, PunditProvider } from 'pundit'
@chrisalley chrisalley self-assigned this Sep 14, 2023
@chrisalley chrisalley added the bug label Sep 14, 2023
chrisalley added a commit that referenced this issue Dec 26, 2024
chrisalley added a commit that referenced this issue Dec 26, 2024
chrisalley added a commit that referenced this issue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant