Merge pull request #65 from jpogran/GH-331-fix-go-to-definition

(GH-66) Fix go to definition

Author: michaeltlombardi

lib/puppet-languageserver.rb

@@ -18,6 +18,7 @@
     puppet_parser_helper
     puppet_helper
     facter_helper
+    uri_helper
     puppet_monkey_patches
     providers
   ].each do |lib|

lib/puppet-languageserver/manifest/definition_provider.rb

@@ -70,7 +70,7 @@ def self.type_or_class(resource_name)
         item = PuppetLanguageServer::PuppetHelper.get_class(resource_name) if item.nil?
         unless item.nil?
           return LanguageServer::Location.create(
-            'uri' => 'file:///' + item.source,
+            'uri' => PuppetLanguageServer::UriHelper.build_file_uri(item.source),
             'fromline' => item.line,
             'fromchar' => 0,
             'toline' => item.line,
@@ -85,7 +85,7 @@ def self.function_name(func_name)
         item = PuppetLanguageServer::PuppetHelper.function(func_name)
         return nil if item.nil? || item.source.nil? || item.line.nil?
         LanguageServer::Location.create(
-          'uri' => 'file:///' + item.source,
+          'uri' => PuppetLanguageServer::UriHelper.build_file_uri(item.source),
           'fromline' => item.line,
           'fromchar' => 0,
           'toline' => item.line,

lib/puppet-languageserver/uri_helper.rb

@@ -0,0 +1,7 @@
+module PuppetLanguageServer
+  module UriHelper
+    def self.build_file_uri(path)
+      path.start_with?('/') ? 'file://' + path : 'file:///' + path
+    end
+  end
+end

spec/languageserver/unit/puppet-languageserver/uri_helper_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe 'uri_helper' do
+  describe '#build_file_uri' do
+    it 'should return /// without leading slash' do
+      test = PuppetLanguageServer::UriHelper.build_file_uri('C:\foo.pp')
+      expect(test).to eq('file:///C:\foo.pp')
+    end
+    it 'should return // with a leading slash' do
+      test = PuppetLanguageServer::UriHelper.build_file_uri('/opt/foo/foo.pp')
+      expect(test).to eq('file:///opt/foo/foo.pp')
+    end
+  end
+end