-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Test.QuickCheck.Gen to seperate repo? #104
Comments
I don't think this needs to have anything to do with quickcheck, it seems what you're asking about is just a stateful |
The stateful MonadGen instance which i'm asking is already implemented here as I think about renaming Test.QuickCheck.Gen to Random.LCG.Gen and move it in a repo purescript-lcg-gen |
There's not really very much left in this library if you take Test.QuickCheck.Gen out. Is there a problem with depending on quickcheck? |
It would still provide I think if we were to make a separate library we'd want it to be |
It's a discoverability problem. If you just need to generate random data, but aren't using this data for testing purposes, then it's easy to assume that quickcheck is the wrong library for that job.
I think small libraries are fine. |
Is there any interest in doing this as part of the 0.14 library updates? Otherwise, we can reconsider it for 0.15. |
Yes. I would like this to occur, but I'm not sure about others. |
I think small libraries are a pain, and rearranging things into separate libraries is a breaking change. I’m not super keen on this. |
Actually, I suppose the original proposal isn’t necessarily breaking. It would be a bit awkward to indefinitely re-export this new Gen library from Test.QuickCheck.Gen though (for example, any breaking change in our new Gen library would have to imply a breaking change in quickcheck too), so I think we’d want to have a deprecation cycle and then remove it. But my main concern is really that we have too many small libraries at the centre of the ecosystem, and I think the discoverability issue could be mostly solved by writing a half decent blog post called “generating random data in PureScript with quickcheck” or something. |
There's a lot of truth to this (or even updating this repo's docs / Readme) to state that, so people can find it via Google. On another hand, if |
This is something I still think should be done. |
This still doesn't solve the problem of As a way forward, here's what I'm proposing that doesn't cause any breaking changes. I can fork this repo, drop all the |
There are cases when you need to random values and the Gen monad will be handy in that case. It would be great if the Test.QuickCheck.Gen monad was published as purescript-lcg-gen (as Random.LCG.Gen) or something and reexported from Test.QuickCheck.Gen for compatibility reasons.
If this seams desirable please create a repo and will volunteer with PRs
The text was updated successfully, but these errors were encountered: