Print compact stats instead of verbose when no errors or warnings (#1254)

Author: fsoikin

CHANGELOG.md

@@ -13,6 +13,7 @@ Other improvements:
 - Fix output truncation with `--json-errors`, many warnings and build failure (#1199)
 - Update README with info about depending on a freshly added library
 - Fixed globbing issue where `/.spago` behaves differently than `.spago` in `.gitignore`
+- Fixed empty output for `--verbose-stats` when there are no errors or warnings.
 
 ## [0.21.0] - 2023-05-04
 

src/Spago/Psa/Output.purs

@@ -1,16 +1,17 @@
 -- A majority of this code was copied from
 -- - https://github.com/natefaubion/purescript-psa-utils
--- 
+--
 -- To fullfil license requirements
 --   Copyright © Nathan Faubion
 --   https://opensource.org/license/mit/
 module Spago.Psa.Output
-  ( buildOutput
-  , Output
+  ( Output
   , OutputStats
   , annotatedError
-  , trimPosition
+  , buildOutput
+  , initialStats
   , trimMessage
+  , trimPosition
   ) where
 
 import Prelude

src/Spago/Psa/Printer.purs

@@ -1,6 +1,6 @@
 -- A majority of this code was copied from
 -- - https://github.com/natefaubion/purescript-psa-utils
--- 
+--
 -- To fullfil license requirements
 --   Copyright © Nathan Faubion
 --   https://opensource.org/license/mit/
@@ -136,12 +136,15 @@ renderStats stats =
 
 renderVerboseStats :: OutputStats -> D.Doc Ansi.GraphicsParam
 renderVerboseStats stats =
-  renderStatCols
-    { col1: warningLabels <> errorLabels
-    , col2: srcWarnings <> srcErrors
-    , col3: libWarnings <> libErrors
-    , col4: allWarnings <> allErrors
-    }
+  if Array.null warnings && Array.null errors then
+    renderStats stats
+  else
+    renderStatCols
+      { col1: warningLabels <> errorLabels
+      , col2: srcWarnings <> srcErrors
+      , col3: libWarnings <> libErrors
+      , col4: allWarnings <> allErrors
+      }
   where
   warnings = Array.sort (FO.keys stats.allWarnings)
   errors = Array.sort (FO.keys stats.allErrors)

test/Spago/Unit.purs

@@ -4,10 +4,12 @@ import Prelude
 
 import Test.Spago.Unit.CheckInjectivity as CheckInjectivity
 import Test.Spago.Unit.FindFlags as FindFlags
+import Test.Spago.Unit.Printer as Printer
 import Test.Spec (Spec)
 import Test.Spec as Spec
 
 spec :: Spec Unit
 spec = Spec.describe "unit" do
   FindFlags.spec
   CheckInjectivity.spec
+  Printer.spec

test/Spago/Unit/Printer.purs

@@ -0,0 +1,25 @@
+module Test.Spago.Unit.Printer where
+
+import Prelude
+
+import Data.String (joinWith)
+import Dodo as Dodo
+import Spago.Psa.Output (initialStats)
+import Spago.Psa.Printer (renderVerboseStats)
+import Test.Prelude (shouldEqual)
+import Test.Spec (Spec)
+import Test.Spec as Spec
+
+spec :: Spec Unit
+spec = do
+  Spec.describe "renderVerboseStats" do
+    Spec.it "renders regular stats with all zeroes when there are no errors or warnings" do
+      printDoc (renderVerboseStats initialStats) `shouldEqual`
+        joinWith "\n"
+        [ "           Src   Lib   All"
+        , "Warnings     0     0     0"
+        , "Errors       0     0     0"
+        ]
+
+  where
+    printDoc = Dodo.print Dodo.plainText Dodo.twoSpaces